ibc rate limit module NTRN-393 #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quasisamurai
force-pushed
the
feat/ibc-rate-limit
branch
from
022dbff
to
aa66712
Compare
…bc-rate-limit # Conflicts: # app/app.go
quasisamurai
force-pushed
the
feat/ibc-rate-limit
branch
from
e7e1ead
to
ae40a29
Compare
… versions thows an err
quasisamurai
force-pushed
the
feat/ibc-rate-limit
branch
from
705999b
to
30f6557
Compare
# Conflicts: # app/app.go
quasisamurai
force-pushed
the
feat/ibc-rate-limit
branch
from
dd6110e
to
2ec4d09
Compare
# Conflicts: # app/upgrades/types.go # app/upgrades/v5.0.0/constants.go # app/upgrades/v5.0.0/upgrades.go
pr0n00gler
previously approved these changes
Oct 1, 2024
pr0n00gler
reviewed
Oct 1, 2024
| suite.RegisterRateLimitingContract(addr) | ||
|
|
||
| // send 2.5% (quota is 5%) | ||
| fmt.Printf("Sending %s from A to B. Represented in chain A as wrapped? %v\n", denom, !native) |
There was a problem hiding this comment.
Remove printlns, please
There was a problem hiding this comment.
discussed in dms, we decided to do so
|
|
||
| // send 2.5% (quota is 5%) | ||
| fmt.Println("trying to send ", sendAmount) | ||
| r, _ := suite.AssertSend(true, suite.MessageFromAToB(denom, sendAmount)) |
There was a problem hiding this comment.
errors are not handles, fix it everywhere, please
There was a problem hiding this comment.
there is no need for that as soon as AssertSend is designed to handle (or expect) the error. behaviour depends on the first parameter
sotnikov-s
reviewed
Oct 2, 2024
sotnikov-s
approved these changes
Oct 2, 2024
pr0n00gler
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a neutron's adaptation of Osmosis' ibc-rate-limit.
It includes:
TASK