Tests cleanup #11852
whatston3Annotations
12 warnings
|
YAML Linter
The following actions uses node12 which is deprecated and will be forced to run on node16: space-wizards/submodule-dependency@v0.1.5. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
YAML Linter
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3.6.0, space-wizards/submodule-dependency@v0.1.5, actions/setup-dotnet@v3.2.0. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
YAML Linter:
RobustToolbox/Robust.Shared/ProfileOptSetup.cs#L16
Unreachable code detected
|
|
YAML Linter:
RobustToolbox/Robust.Shared/Toolshed/TypeParsers/SessionTypeParser.cs#L46
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
|
YAML Linter:
RobustToolbox/Robust.Shared/Player/Filter.cs#L279
'EntitySystem.TryGet<T>(out T?)' is obsolete: 'Either use a dependency, resolve and cache IEntityManager manually, or use EntityManager.System<T>()'
|
|
YAML Linter:
RobustToolbox/Robust.Shared/Prototypes/PrototypeManager.YamlValidate.cs#L72
The variable 'defaultErrorOccurred' is assigned but its value is never used
|
|
YAML Linter:
RobustToolbox/Robust.Shared/GameObjects/Systems/SharedUserInterfaceSystem.cs#L226
'BoundUserInterface.DeferredClose' is obsolete
|
|
YAML Linter:
RobustToolbox/Robust.Shared/GameObjects/Systems/SharedUserInterfaceSystem.cs#L407
'BoundUserInterface.DeferredClose' is obsolete
|
|
YAML Linter:
RobustToolbox/Robust.Shared/GameObjects/Systems/SharedUserInterfaceSystem.cs#L458
'BoundUserInterface.DeferredClose' is obsolete
|
|
YAML Linter:
RobustToolbox/Robust.Shared/Containers/SharedContainerSystem.cs#L580
'SharedContainerSystem.TryGetContainingContainer(EntityUid, out BaseContainer?, MetaDataComponent?, TransformComponent?)' is obsolete: 'Use Entity<T> variant'
|
|
YAML Linter:
RobustToolbox/Robust.Shared/Containers/SharedContainerSystem.cs#L650
'SharedContainerSystem.TryGetContainingContainer(EntityUid, out BaseContainer?, MetaDataComponent?, TransformComponent?)' is obsolete: 'Use Entity<T> variant'
|
|
YAML Linter:
RobustToolbox/Robust.Shared/Containers/SharedContainerSystem.cs#L663
'SharedContainerSystem.TryGetContainingContainer(EntityUid, out BaseContainer?, MetaDataComponent?, TransformComponent?)' is obsolete: 'Use Entity<T> variant'
|