Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make APCs emp (when turned on) after a random delay during a power grid check #1906

Closed

Conversation

dvir001
Copy link
Contributor

@dvir001 dvir001 commented Aug 24, 2024

About the PR

Taken from Sector-Umbra/Sector-Umbra#24

Why / Balance

Adds a system which makes device emp itself when in a overloaded state. This can be adapted to be used for other devices which are not APCs.

How to test

Buy any ship
add game event PowerGridCheck
Try to screwdriver the APC
Try to toggle the APC

Media

N/A

Breaking changes

N/A

Changelog
🆑

  • tweak: APCs will now emp itself during a power grid check when they are turned on.

Simyon264 and others added 3 commits August 24, 2024 18:14
…r grid check. (new-frontiers-14#24)

* Make APCs explode after a random delay during a power grid check.

* Change buzz message according to review

* Make message hidden in chat

* Increase delay between buzzes

* Named parameters

---------

Co-authored-by: TsjipTsjip <19798667+TsjipTsjip@users.noreply.github.com>
@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Aug 24, 2024
@Sinis-Boop
Copy link

I should not have told him how to reset APCs 😭

@Tych0theSynth
Copy link
Contributor

I'm really not entirely sure how I feel about this, but I do feel largely negative. Having experienced this in the past, it works fine on a station where you can quickly have an engineer in with an APC board to fix it up.
It's going to be FAR more debilitating on shuttles and I feel like this effect will be even more punishing to newer players.

Of particular worry is if the cruise setting on the shuttle console continues when it's turned off. If this is the case, a destroyed APC could keep someone flying and unable to stop for a VERY long time and will make rescue extremely difficult.

How much damage does the explosion do? Could it cause hull breaches? Could it kill someone?

What do you do if there's nobody around who can fix it? That's basically your round over and ship dead for a tiny reason.

@Houtblokje
Copy link
Contributor

I'm really not entirely sure how I feel about this, but I do feel largely negative. Having experienced this in the past, it works fine on a station where you can quickly have an engineer in with an APC board to fix it up. It's going to be FAR more debilitating on shuttles and I feel like this effect will be even more punishing to newer players.

Of particular worry is if the cruise setting on the shuttle console continues when it's turned off. If this is the case, a destroyed APC could keep someone flying and unable to stop for a VERY long time and will make rescue extremely difficult.

How much damage does the explosion do? Could it cause hull breaches? Could it kill someone?

What do you do if there's nobody around who can fix it? That's basically your round over and ship dead for a tiny reason.

I mean I do like the idea of having more things for engineers to do, but I agree that this might be too punishing.

@Tych0theSynth
Copy link
Contributor

I'm really not entirely sure how I feel about this, but I do feel largely negative. Having experienced this in the past, it works fine on a station where you can quickly have an engineer in with an APC board to fix it up. It's going to be FAR more debilitating on shuttles and I feel like this effect will be even more punishing to newer players.
Of particular worry is if the cruise setting on the shuttle console continues when it's turned off. If this is the case, a destroyed APC could keep someone flying and unable to stop for a VERY long time and will make rescue extremely difficult.
How much damage does the explosion do? Could it cause hull breaches? Could it kill someone?
What do you do if there's nobody around who can fix it? That's basically your round over and ship dead for a tiny reason.

I mean I do like the idea of having more things for engineers to do, but I agree that this might be too punishing.

Oh don't get me wrong, I'm ALL for giving engineers more to do. I don't exactly see this encouraging more people to play engineer, however.

@dvir001 dvir001 changed the title Make APCs explode (when turned on) after a random delay during a power grid check Make APCs emp (when turned on) after a random delay during a power grid check Aug 24, 2024
@dvir001
Copy link
Contributor Author

dvir001 commented Aug 24, 2024

What explosion? this PR is about EMP, no idea what you all talking about.

@Houtblokje
Copy link
Contributor

What explosion? this PR is about EMP, no idea what you all talking about.

give EMP's a random chance to fry a non-essential circuitboard (so everything other than doors, apc's, shuttle consoles, station consoles and anything else you really need for the ship to function) haha

@Leander-0
Copy link
Contributor

first half

@MagnusCrowe
Copy link
Contributor

Why? Your why section doesn't answer the question.

@Cheackraze
Copy link
Member

is this all have to do with the grid check event? I'm fairly certain that toggling the power on the APC to 'skip' it has been intended since ss13, likely for a decade at this point. In my opinion, I like that advanced game knowledge can be utilized like that to help mitigate otherwise mundane events. Like Tych0 said, on stations it requires an engineer's access (and for that engineer to be smart enough) to do, and on ships I see no reason to allow robust players ways to interact more with the game in general. Enduring a power outage isnt really all that thrilling, and just being forced to sit through it for the 2-3 minutes i dont think adds to anybody's experience.

@Cheackraze
Copy link
Member

Intentional APC disruption like EMP or sabotage, etc., obviously shouldn't be so easily bypassed of course, since that's a more direct kind of interaction anyway.

@github-actions github-actions bot added the Merge Conflict This PR has conflicts that prevent merging label Sep 7, 2024
Copy link
Contributor

github-actions bot commented Sep 7, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added Changes: Shaders and removed Merge Conflict This PR has conflicts that prevent merging labels Sep 7, 2024
@dvir001
Copy link
Contributor Author

dvir001 commented Oct 3, 2024

Remaking this into something else

@dvir001 dvir001 closed this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants