Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NFSD medals, The Glorious Order #1943

Merged

Conversation

whatston3
Copy link
Contributor

About the PR

Adds an NFSD-specific medal case and a set of seven new medals for different feats (both in service and for civilians). Adds a craftable gaudy monstrosity of a medal for pompous idiocy.

Thank you to GhostPrince for the sprites, I hope my minor touchups (the lengths of the ribbon on the bronze and silver star, striping on the gold star) and pallet swaps (civilian medal ribbons) aren't awful.

Why / Balance

Recognition of effort is good and promotes roleplay. The Glorious Order is a dumb joke item, but I think it's funny.

How to test

  1. Warp to/spawn on NFSD Outpost
  2. Enter the Sheriff's office.
  3. Look at the medal case, admire the little golden shield.
  4. Open the medal case, inspect the names, descriptions, and images of the medals. Try them on, they should all only show when your character is facing the camera.
  5. Craft The Glorious Order, it should give you enough time to contemplate ruining several perfectly good medals for a stupid gimmick.
  6. Try it on, it should show when the character is facing the camera, and on both side views.

Media

image

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

  • add: The NFSD has a new, more appropriate set of medals to be given out.
  • add: A new medal, the Glorious Order of the Frontier, 1st Class can now be crafted.

Copy link
Contributor

github-actions bot commented Sep 5, 2024

RSI Diff Bot; head commit 6218d8b merging into caed994
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Clothing/Neck/Medals/blood_drop.rsi

State Old New Status
equipped-NECK Added
icon Added

Resources/Textures/_NF/Clothing/Neck/Medals/glorious_order.rsi

State Old New Status
equipped-NECK Added
icon Added

Resources/Textures/_NF/Clothing/Neck/Medals/shield_bronze.rsi

State Old New Status
equipped-NECK Added
icon Added

Resources/Textures/_NF/Clothing/Neck/Medals/shield_civviegold.rsi

State Old New Status
equipped-NECK Added
icon Added

Resources/Textures/_NF/Clothing/Neck/Medals/shield_gold.rsi

State Old New Status
equipped-NECK Added
icon Added

Resources/Textures/_NF/Clothing/Neck/Medals/shield_silver.rsi

State Old New Status
equipped-NECK Added
icon Added

Resources/Textures/_NF/Clothing/Neck/Medals/star_civviesilver.rsi

State Old New Status
equipped-NECK Added
icon Added

Resources/Textures/_NF/Clothing/Neck/Medals/star_gold.rsi

State Old New Status
equipped-NECK Added
icon Added

Resources/Textures/_NF/Objects/Storage/nfsdmedalcase.rsi

State Old New Status
closed Added
inhand-left Added
inhand-right Added
open Added

@ErhardSteinhauer ErhardSteinhauer merged commit 2e09458 into new-frontiers-14:master Sep 6, 2024
15 checks passed
FrontierATC added a commit that referenced this pull request Sep 6, 2024
@whatston3 whatston3 deleted the 2024-09-04-nfsd-medals branch September 21, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants