Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added much needed Air Alarms to the Crescent #1945

Merged
merged 13 commits into from
Oct 7, 2024

Conversation

KyuPolaris
Copy link
Contributor

@KyuPolaris KyuPolaris commented Sep 6, 2024

About the PR

Adds multiple Air Alarms around the Crescent.

Why / Balance

The large ship does not have a single air alarm for an engineer on board to use to assist with atmos issues. Also future proofing for when Alerts Computer is fully implemented (soon™)

How to test

  • Spawn/Buy Crescent
  • Witness Air Alarms in different areas of ship

Media

image
image
image
image
image
image
image
image

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

n/a (it is my first time doing mapping at all, I didn't notice any and the ship didn't implode)

Changelog

🆑

  • tweak: The Crescent now has been fitted with Air Alarms, engineers rejoice!

@github-actions github-actions bot added Map-Shuttle Map - Shuttle No C# labels Sep 6, 2024
@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Sep 7, 2024
@dvir001
Copy link
Contributor

dvir001 commented Sep 29, 2024

Only issue standing is the none local (FTL) naming to Air Alarms but we might be able to just merge and fix after.

@dvir001 dvir001 self-requested a review October 7, 2024 16:36
Copy link
Contributor

@dvir001 dvir001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed more issues, added AI but not the job since there are alot of issues with it.

Still need to fix cameras + air alarm to use ftl file.

@dvir001 dvir001 merged commit 1390c65 into new-frontiers-14:master Oct 7, 2024
13 checks passed
FrontierATC added a commit that referenced this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Map-Shuttle Map - Shuttle No C# Status: Needs Review This PR is awaiting reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants