Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parcel/Menace Directional Fans #1981

Merged
merged 4 commits into from
Sep 15, 2024
Merged

Conversation

PeccNeck
Copy link
Contributor

@PeccNeck PeccNeck commented Sep 10, 2024

About the PR

Replaced tiny fans on the Parcel and its piracy sister ship Menace with directional fans.

Why / Balance

#1980
Not only is it the new thing, these ships are in special need of it. Those shutters come down right on those tiny fan tiles and delete the atmosphere; so you end up with a perma-vacuum tile that tries to suffocate you every time you go to enter or exit your shuttle.

How to test

  • Spawn a Parcel or Menace.
  • Behold, directional fans.
  • Lower the shutters, then raise them again.
  • Step onto the fan.
  • Behold, you're no longer dying of low pressure and asphyxiation.

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog
N/A

@dvir001
Copy link
Contributor

dvir001 commented Sep 14, 2024

No need for Changelog

@dvir001 dvir001 self-requested a review September 14, 2024 21:11
@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Sep 14, 2024
@dvir001 dvir001 merged commit 2bd7120 into new-frontiers-14:master Sep 15, 2024
12 checks passed
@PeccNeck PeccNeck deleted the dfan-parcel branch October 13, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Map-Shuttle Map - Shuttle No C# Status: Needs Review This PR is awaiting reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants