Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Respawn Lenience (comment out 1894) #2072

Closed
wants to merge 3 commits into from

Conversation

whatston3
Copy link
Contributor

About the PR

Reverts 1894.

Why / Balance

Abuse. Left these commented and not removed as I'd like to get back to them.

How to test

  1. Observe, 20 minute respawn timer.
  2. Take a ghost role, exit, 20 minute respawn timer.
  3. Spawn, gib bang stick yourself, 20 minute respawn timer.

Media

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

  • remove: Respawn timers have been reverted.

@dvir001 dvir001 self-requested a review September 25, 2024 13:20
@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Sep 25, 2024
Copy link
Contributor

@dvir001 dvir001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Literally 1894.

I think ghost radar max IFF to 256 will still be a more clean fix.

@github-actions github-actions bot added the Merge Conflict This PR has conflicts that prevent merging label Sep 27, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added Merge Conflict This PR has conflicts that prevent merging and removed Merge Conflict This PR has conflicts that prevent merging labels Sep 27, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@whatston3
Copy link
Contributor Author

whatston3 commented Oct 4, 2024

Going to close this - the majority of the exploitable issues should be resolved, can reopen and update if needed.

Issues resolved:

  • Ghost radar IFF range reduced to 256 meters (upstream merge) - items off radar do not display a label, you can't get a relative position (e.g. ~135 degrees to Tinnia's, roughly 3 km away)
  • Ghost radar coords removed (upstream merge)
  • LP Bravo and Pirate Cove are no longer valid warp targets for non-admins (Make LP Bravo and Pirate Cove admin-only warp points. #2120)

Getting an exact position of players or stations outside of reports over the radio or ghost-visible comms, lobby-side crew monitor info, or IDing a ship's IFF as a ghost should be difficult, should fall into client-side modification, metacommunications, or intentional griefing. The existence of all of these, sad as they are, should fall into being administrative issues.

@whatston3 whatston3 closed this Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# Merge Conflict This PR has conflicts that prevent merging Status: Needs Review This PR is awaiting reviews UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants