Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSF Prowler: Update Again #2094

Merged
merged 9 commits into from
Oct 17, 2024

Conversation

Tych0theSynth
Copy link
Contributor

About the PR

Updates the NSF Prowler a little bit, largely for compliance with space law changes and mapping requirements.

  • Directional fans have replaced tiny fans.
  • Fuel locker was added.
  • New airlocks.
  • EVA suit storage.
  • Shelving.
  • Smoothed hull profile.
  • Tiles under walls removed (hopefully I got them all) and some other tiles adjusted.
  • Small adjustments to engineering infrastructure.
  • Added some posters. New NFSD signs.
  • Shifted the radar console over a couple of tiles so it can't be used at the same time as the shuttle console.
  • Adjusted price and ship description.

Why / Balance

Space law now designates when NFSD officers should and shouldn't be using hardsuits, so the suit storage area was adjusted to now have EVA lockers as well as the hardsuit units. I had to remove the racks for this, so shelving was added around the ship so too much storage isn't lost. There's a sturdy shelf in the armoury now for storing ammunition.

Directional fans are now a thing, so the ship is compliant with those now.

Price was adjusted also, as it appraises at just under 35k at purchase.

How to test

Checkout the branch, buy the ship. Go prowling.

Media

2024-09-27 15_43_41-Frontier Station
Uninitialised. Spawns showing.

2024-09-27 15_45_08-Frontier Station
Uninitialised.

2024-09-27 15_45_59-Frontier Station
Initialised.

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Nil.

Changelog
🆑

  • tweak: Updated the NSF Prowler.

@github-actions github-actions bot added Map-Shuttle Map - Shuttle No C# labels Sep 27, 2024
@Tych0theSynth
Copy link
Contributor Author

Tagging @Kesiath as this PR concerns a ship they initially designed.
Also tagging issue #1980 as this adds directional fans.

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Merge Conflict This PR has conflicts that prevent merging label Sep 27, 2024
@github-actions github-actions bot removed the Merge Conflict This PR has conflicts that prevent merging label Sep 27, 2024
@ErhardSteinhauer
Copy link
Contributor

Resolved the conflict, replaced old weapon racks with new ones.

@Tych0theSynth
Copy link
Contributor Author

Resolved the conflict, replaced old weapon racks with new ones.

Ah, thank you Erhard!

@Jakumba
Copy link

Jakumba commented Oct 15, 2024

Sorry if this is an annoying question, but would it be possible to re-add the cellcharger removed from the cockpit? It could maybe fit in the dorm on the table.
Also, are the additional EVA lockers necessary? If my understanding of SOP is correct the patrol hardsuits are acceptable to wear at heat zero. Losing the vending machines would also be quite a blow to the ships flexability imo.

@Tych0theSynth
Copy link
Contributor Author

Tych0theSynth commented Oct 15, 2024

Sorry if this is an annoying question, but would it be possible to re-add the cellcharger removed from the cockpit? It could maybe fit in the dorm on the table. Also, are the additional EVA lockers necessary? If my understanding of SOP is correct the patrol hardsuits are acceptable to wear at heat zero. Losing the vending machines would also be quite a blow to the ships flexability imo.

Incorrect. From the SOP, softsuits are a requirement at both heat zero and heat one. Hardsuits are not authorised until heat two!
I'm not sure where I'd fit a charger in those places. You already get three omnidirectional wallmounts which can charge batteries as well as rechargeable equipment!

Vendors are generally being removed from ships. You always start at the NFSDO where you should be equipping yourself with everything you need, and there's always the Empress and uplink.

@Jakumba
Copy link

Jakumba commented Oct 15, 2024

Sorry if this is an annoying question, but would it be possible to re-add the cellcharger removed from the cockpit? It could maybe fit in the dorm on the table. Also, are the additional EVA lockers necessary? If my understanding of SOP is correct the patrol hardsuits are acceptable to wear at heat zero. Losing the vending machines would also be quite a blow to the ships flexability imo.

Incorrect. From the SOP, softsuits are a requirement at both heat zero and heat one. Hardsuits are not authorised until heat two! I'm not sure where I'd fit a charger in those places. You already get three omnidirectional wallmounts which can charge batteries as well as rechargeable equipment!

Vendors are generally being removed from ships. You always start at the NFSDO where you should be equipping yourself with everything you need, and there's always the Empress and uplink.

Ah to be clear re: the patrol suits, I was given to understand that they counted as soft suits, due to existing prior to the green armourless EVA suit, and that hard suit with regards to the SOP, specifically referenced the uplink purchasble combat suits and above. Is this no longer the case?

@Tych0theSynth
Copy link
Contributor Author

Ah to be clear re: the patrol suits, I was given to understand that they counted as soft suits, due to existing prior to the green armourless EVA suit, and that hard suit with regards to the SOP, specifically referenced the uplink purchasble combat suits and above. Is this no longer the case?

From my understanding, softsuits are softsuits and hardsuits are hardsuits.
You'll notice that both the Broadhead and the Wendigo both have EVA and hardsuit storage also!

@dvir001 dvir001 self-requested a review October 17, 2024 22:51
@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Oct 17, 2024
@dvir001 dvir001 merged commit ce248f0 into new-frontiers-14:master Oct 17, 2024
15 checks passed
FrontierATC added a commit that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Map-Shuttle Map - Shuttle No C# Status: Needs Review This PR is awaiting reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants