Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces Barnacle tiny fans with directional fans. #2097

Merged
merged 7 commits into from
Oct 11, 2024

Conversation

dustylens
Copy link
Contributor

About the PR

Tiny fans are now directional fans.
Plasma fuel locker added.
Some work done to add atmos compliance. Take a look at let me know if that seems acceptable. Didn't want to change the footprint.

Why / Balance

Compliance.

How to test

Fans fuel gas

Media

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

  • tweak: Updated Barnacle with directional fans.

Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seem alright. YAML changes look sensible, atmospherics seem fine, locker uses one stack of fuel, no new or missing fans, all directional and well rotated. Blast doors operate as expected.

Value changed to give a ~10% margin, can be fixed later, but seems reasonable to start.

@whatston3 whatston3 merged commit 99a949c into new-frontiers-14:master Oct 11, 2024
14 checks passed
FrontierATC added a commit that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants