Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds FSB Spirit poster and two EMS signs. #2102

Merged
merged 12 commits into from
Oct 9, 2024

Conversation

dustylens
Copy link
Contributor

@dustylens dustylens commented Sep 28, 2024

About the PR

Adds a poster for the FSB Spirit for display and for incorporation into the dead drop library.
Adds two styles of "EMS" signs as alternatives to the MED sign, both for personal use and for anyone who thinks they don't look awful and would like to incorporate them.

Edit: Adds an addition poster from user incongruenciaastrologica on discprd.

Why / Balance

Advertisement/character for the Spirit.
Alternative choice sign for medical signs/posters who

How to test

Place posters. Check descriptions. Make sure they're part of the general smuggling list.

Media

posters
ss+(2024-09-28+at+11 19 58)

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

  • add: New poster for the FSB Spirit and two new EMS signs.

Copy link
Contributor

github-actions bot commented Sep 28, 2024

RSI Diff Bot; head commit 7895287 merging into 8735b54
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Structures/Wallmounts/signs.rsi

State Old New Status
bus Modified
dock Modified
ems1 Added
ems2 Added

Resources/Textures/_NF/Structures/Wallmounts/posters.rsi

State Old New Status
nf_poster7_contraband Added
nf_poster8_contraband Added

Edit: diff updated after 7895287

@dustylens
Copy link
Contributor Author

Some small poster updates performed during a live chit chat. Feel much better about the end result for the horizontal poster and the last minute provision from incongruenciaastrologica.

Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New posters seem fine, YAML looks alright.

For your consideration, I've made a square version of the medroach poster by shrinking in the sides and moving the mothroach over the very bottom of the text (cross made pale yellow for contrast against the green text)
image

Context in-game:
image

Better matches the size of the other posters. Happy with or without this, but food for thought. Changes to poster up at whatston3/Poster-Child-suggestions

@dustylens
Copy link
Contributor Author

Poster revision looks fine to me. Not my work but I will accept on behalf of the other person.

Copy link
Contributor

github-actions bot commented Oct 9, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Merge Conflict This PR has conflicts that prevent merging label Oct 9, 2024
@dustylens
Copy link
Contributor Author

:(

@github-actions github-actions bot removed the Merge Conflict This PR has conflicts that prevent merging label Oct 9, 2024
@whatston3 whatston3 merged commit 10208fb into new-frontiers-14:master Oct 9, 2024
14 checks passed
FrontierATC added a commit that referenced this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants