Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces Spectre tiny fans with directional fans. #2105

Merged
merged 10 commits into from
Oct 17, 2024

Conversation

dustylens
Copy link
Contributor

@dustylens dustylens commented Sep 28, 2024

About the PR

Tiny fans out, directional fans in.
Updated the atmos setup. Should be good to go from round start now.
There seemed to be an issue with the reactor not initializing. It seemed to not have fuel. I believe that should be corrected now.
Removed loose AME fuel, mapped fuel locker.

Why / Balance

Compliance.

How to test

Check atmos.
Check power.
Check fans.

Media

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

  • tweak: Updated Spectre with directional fans.

Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recoloured a gas port, removed an inaccessible AME can in an old AME slot name.

There's an unanchored gas port by the starboard waste outlet where the portable scrubber is - as we mentioned, if that section of the ship could be moved around, maybe reposition the fax machine and use the spot where the table is as a gas outlet, might work better.

@dustylens
Copy link
Contributor Author

Went a bit out of scope to work on some of the issues outlined. Rebuilt the waste room a bit and moved the fax system to the bridge. Which seems appropriate.

Seems to work fine enough.

ss+(2024-10-12+at+06 04 57)
ss+(2024-10-12+at+06 06 06)

@whatston3 whatston3 dismissed their stale review October 12, 2024 14:30

Dismissing my review, changes seem fine.

@dvir001 dvir001 self-requested a review October 17, 2024 23:29
Copy link
Contributor

@dvir001 dvir001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trash lines into space
TV On a table

God is dead, good to go for now but will need some other edits after this.

@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Oct 17, 2024
@dvir001 dvir001 merged commit caf6fcd into new-frontiers-14:master Oct 17, 2024
15 checks passed
FrontierATC added a commit that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Map-Shuttle Map - Shuttle No C# Status: Needs Review This PR is awaiting reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants