Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced Stellaris tiny fans with directional fans. #2109

Closed

Conversation

dustylens
Copy link
Contributor

About the PR

Fans.
Slight remodel to the engineering bay to allow for atmos compliance. Atmo systems repiped slightly to accommodate new space requirements.
Added fuel locker.
Looked around and reflected on how maybe the old bird may be yearning for retirement.

Why / Balance

Compliance.

How to test

Check atmos.
Check power.
Check locker.
Check fans.

Media

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

  • tweak: Replace Stellaris tiny fans with directional fans.

@chrome-cirrus
Copy link
Contributor

chrome-cirrus commented Oct 2, 2024

Checked this out, directional fans on both docks, atmos looks good. Revamped engineering room has the right stuff connected to the right stuff. Fuel is accessible.

dock1
dock2
atmos

Minor note: Air alarm in the freezer was going off right when I bought/first boarded the ship. It recovered pretty quickly so doesn't really matter. Might need fixgridatmos run for the prefill to be right?

@Tych0theSynth
Copy link
Contributor

Tych0theSynth commented Oct 2, 2024

Minor note: Air alarm in the freezer was going off right when I bought/first boarded the ship. It recovered pretty quickly so doesn't really matter. Might need fixgridatmos run for the prefill to be right?

It's more likely that the air alarm is linked to the freezer vent, which it doesn't really need to be. If it is, unlinking will mitigate that problem.

EDIT: Oh right, it has an unnecessary air sensor in there too. Probably don't need that.

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Merge Conflict This PR has conflicts that prevent merging label Oct 12, 2024
@dvir001
Copy link
Contributor

dvir001 commented Oct 16, 2024

This will need a remake if the issues still there since the ship got edited on another PR.

@dvir001 dvir001 closed this Oct 16, 2024
@dustylens
Copy link
Contributor Author

dustylens commented Oct 16, 2024

What PR? What issues?

Is it something that can be fixed? Should be fixed? Is fixed?

@dvir001
Copy link
Contributor

dvir001 commented Oct 17, 2024

The food PR, the fans and stuff were replaced in it so the yml got broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Map-Shuttle Map - Shuttle Merge Conflict This PR has conflicts that prevent merging No C#
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants