Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vault FTL by deleting the missing prototype #2149

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

Houtblokje
Copy link
Contributor

@Houtblokje Houtblokje commented Oct 4, 2024

About the PR

Fixes #2147

by deleting the BookSecretDocuments entity from the maps.

Why / Balance

Bugfix

How to test

Run the addgamerule command for both vaults, see that they once again spawn properly.

Media

Requirements

Breaking changes

Probably none.

@github-actions github-actions bot added Map-Bluespace Map - Bluespace Event No C# labels Oct 4, 2024
@dvir001
Copy link
Contributor

dvir001 commented Oct 4, 2024

Should be replaced, but ok for now

@dvir001 dvir001 self-requested a review October 4, 2024 21:24
@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Oct 4, 2024
@dvir001
Copy link
Contributor

dvir001 commented Oct 4, 2024

Removed your changelog since you added them with a mistake anyway :| so it wont bug the file

@GreyMario
Copy link
Contributor

GreyMario commented Oct 4, 2024

/Maps/_NF/Bluespace/datacarrier.yml is also affected by a missing PlushieSlips prototype.

I found this while looking at the rest of the bluespace events. Should be the last spawn-blocking issue among them.

@dvir001 dvir001 merged commit 8ec74cb into new-frontiers-14:master Oct 4, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Map-Bluespace Map - Bluespace Event No C# Status: Needs Review This PR is awaiting reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bluespace NT Vault (both sizes) fail to spawn due to missing BookSecretDocuments prototype
3 participants