Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add magic crayon #2157

Merged
merged 8 commits into from
Oct 9, 2024
Merged

Add magic crayon #2157

merged 8 commits into from
Oct 9, 2024

Conversation

Leander-0
Copy link
Contributor

About the PR

As always thanks @GentleButter for the incredible sprites :^)

Adds magic crayon, basically a crayon with 999.999 charges so people that want to do large scale art dont need to buy 30 different packs of crayons. also included on the loadouts for the mere price of 30K.

Why / Balance

Still can be eaten but will take 8 bites so you dont accidentally swallow a crayon the size of a phone if you missclick.

How to test

Get to fun loadouts at the end select the magic crayon.
have 30K to spend.
paint the world red.

Changelog

🆑 Leander

  • add: Added magic crayon and its selection on the Fun loadouts, paint the world with it!

Copy link
Contributor

github-actions bot commented Oct 5, 2024

RSI Diff Bot; head commit d460787 merging into 04096ab
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Objects/Fun/magic_crayon.rsi

State Old New Status
icon-inhand-left Added
icon-inhand-right Added
icon Added

Edit: diff updated after d460787

@whatston3
Copy link
Contributor

I put up a set of suggestions onto whatston3:magic-crayon-suggestions. I think the changes are reasonable, here's what I changed:

Nice things:

  • No more "99700/99999" in the bar
  • Better YAML parenting, smaller definition
  • Animated in-hand sprites
  • Gave attributions to other Paradise sprites missing a commit (mentioned the source DMI) - cleanup for things as I saw them, pardon the mess

Toss ups:

  • Tastes "magical" (it's a magic crayon), not "sweet"
  • Tweaked the description (it should taste magical :( )
  • Renamed ID to CrayonMagic to match with CrayonRainbow, CrayonRed...

No fun allowed:

  • Created a small animated version of the existing rainbow crayon instead of the new sprite, which, while nicely animated, is oddly large.
  • Changed the crayon to be made of nothing, like plastic bananas (no incentives to eat it beyond it tasting like magic).

Small video showing how the crayons look in-game with a normal blue and rainbow crayon for comparison:

2024-10-05.22-28-55.mp4

@Leander-0
Copy link
Contributor Author

Oh wow not only you went above but also beyond, i will be pushing the changes but i do find it a shame that the other sprite was tossed out.

@github-actions github-actions bot added C# FTL and removed No C# labels Oct 6, 2024
@whatston3
Copy link
Contributor

Oh wow not only you went above but also beyond, i will be pushing the changes but i do find it a shame that the other sprite was tossed out.

It's only an opinion, I'm just one guy - I do think it's a nice sprite, and could make for a neat fuel rod or some intermediate refined material, but it seems really big for a crayon. Happy to revert if there's consensus the other way, and don't mean to step on toes.

Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second set of eyes appreciated on this but I'm happy with it.

@dvir001
Copy link
Contributor

dvir001 commented Oct 6, 2024

Missing the option to yeet it and have it embed into someone but overall fine.

@whatston3 whatston3 merged commit f6f4f23 into new-frontiers-14:master Oct 9, 2024
16 checks passed
FrontierATC added a commit that referenced this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants