Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests cleanup #2170

Merged
merged 5 commits into from
Oct 8, 2024
Merged

Tests cleanup #2170

merged 5 commits into from
Oct 8, 2024

Conversation

dvir001
Copy link
Contributor

@dvir001 dvir001 commented Oct 8, 2024

About the PR

Added tests and tests fixups

Breaking changes

Many ships PR's going to show real errors.

Changelog
N/A

@dvir001 dvir001 requested a review from whatston3 October 8, 2024 20:29
@github-actions github-actions bot added No C# Status: Needs Review This PR is awaiting reviews labels Oct 8, 2024
@github-actions github-actions bot added the FTL label Oct 8, 2024
@dvir001 dvir001 requested a review from whatston3 October 8, 2024 21:53
Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright to my eyes.

New credits page looks like this:
image

@dvir001
Copy link
Contributor Author

dvir001 commented Oct 8, 2024

Based

@dvir001 dvir001 merged commit 90ec949 into new-frontiers-14:master Oct 8, 2024
12 checks passed
@dvir001 dvir001 changed the title Add ship tests and extra tests fixups Tests cleanup Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FTL No C# Status: Needs Review This PR is awaiting reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants