Ice and Sandstone walls dont spawn girders

[MisterMecky]

About the PR

Changes ice and sandstone walls to no longer spawn a girder on their destruction

Why / Balance

How to test

1. Spawn Ice Wall / Sandstone Wall
2. Destroy it

Media

2024-10-09.11-13-28.mp4

Requirements

• I have read and am following the Pull Request and Changelog Guidelines.
• I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

🆑

• tweak: Ice and sandstone walls no longer spawn a girder upon their destruction

[dvir001]

Any other asteroid walls have the same issue or just this 2?

[whatston3]

Why not put this in AsteroidWallNF? Then all walls can share the same damage and spawn behaviour (none):

  - type: Destructible
    thresholds:
    - trigger:
        !type:DamageTrigger
        damage: 700 # Approximate strength as mining walls
      behaviors:
      - !type:DoActsBehavior
        acts: [ "Destruction" ]

Suggested changes up here, cherry-pick if you'd like: https://github.com/MisterMecky/frontier-station-14/compare/roidwalls...whatston3:frontier-station-14:roidwalls-suggestion?expand=1

[MisterMecky]

Any other asteroid walls have the same issue or just this 2?

Only these two spawn girders from what I've found, most others are cobble walls ( no girder)

Why not put this in AsteroidWallNF? Then all walls can share the same damage and spawn behaviour (none):

  - type: Destructible
    thresholds:
    - trigger:
        !type:DamageTrigger
        damage: 700 # Approximate strength as mining walls
      behaviors:
      - !type:DoActsBehavior
        acts: [ "Destruction" ]

Suggested changes up here, cherry-pick if you'd like: https://github.com/MisterMecky/frontier-station-14/compare/roidwalls...whatston3:frontier-station-14:roidwalls-suggestion?expand=1

This is a much better solution, though 700 damage seems too high for the walls. At the moment, most walls have a strength of 100 ( all the cobble variants), sand and ice walls have a strength of 300, and necropolis walls have a whopping 1000.

Maybe 300 is a good middle point?

[whatston3]

Made the damage 1000. Pending a mining redesign that gives the PTK a niche to fill beyond blasting everything in sight and sitting comfortably indoors, this is fine.