-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More recyclable items #2179
base: master
Are you sure you want to change the base?
More recyclable items #2179
Conversation
Awesome! This will be such a nice QoL thing... I hate that the only way to get rid of so many items is leaving them on a planet or hurling them into space for GC to eventually delete. |
Literally my last thought as I logged out last night was that it seemed silly that I couldn't recycle pill canisters. Excellent initiative :D |
As someone who obsessively shoves things in the disposal and checks the reclaimer, often being disappointed at the large pile of things that somehow can't be processed in there, I'm especially happy to see this get amended. Things like ammo boxes not recycling is especially annoying, because isn't it just cardboard? Oftentimes people will dump spare ammo and magazines in the disposal and they just pile up. It also seems like individual bullets DO get recycled but I don't know if it's the sprite just being too small or something because they don't seem to automatically get taken in by the magnet when on a conveyor belt.. |
Can't think of anything else that'd be worth adding to the list, so I guess this is ready for review |
Wait for #2209 to confirm no issues. |
Watch "integration tests" start bitching about recycled ammo boxes giving you more "carboard" than you used for crafting them (you used 0). |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
wait for integration test testing still |
About the PR
While there should be more recyclable items in general, in my opinion, I'm not sure if the method proposed in this pull request is the correct approach.
Nonetheless, this PR does expand the list of recyclable items. It generally makes almost every single item that can be found on space wrecks recyclable (same goes for items players spawn with). However, the PR mostly disregards the crafting compositions of items, which results in recycling being quite inefficient and sometimes overlooks the actual sizes of items. For instance, a toolbox, despite being a "ginormous" item, is considered medium-sized for resource yield purposes.
Even though the material value of items is somewhat undercut, I believe this could potentially make salvaging a competitive alternative to mining as a source of raw materials.
Why / Balance
Less entities, more raw resources for crafting.
How to test
Media
Requirements
Breaking changes
Changelog
🆑 erhardsteinhauer