Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More recyclable items #2179

Open
wants to merge 23 commits into
base: master
Choose a base branch
from

Conversation

ErhardSteinhauer
Copy link
Contributor

About the PR

While there should be more recyclable items in general, in my opinion, I'm not sure if the method proposed in this pull request is the correct approach.

Nonetheless, this PR does expand the list of recyclable items. It generally makes almost every single item that can be found on space wrecks recyclable (same goes for items players spawn with). However, the PR mostly disregards the crafting compositions of items, which results in recycling being quite inefficient and sometimes overlooks the actual sizes of items. For instance, a toolbox, despite being a "ginormous" item, is considered medium-sized for resource yield purposes.

Even though the material value of items is somewhat undercut, I believe this could potentially make salvaging a competitive alternative to mining as a source of raw materials.

Why / Balance

Less entities, more raw resources for crafting.

How to test

  1. Spawn, get a shuttle with material reclaimer, recycle everything you can grab on wrecks

Media

Requirements

Breaking changes

Changelog
🆑 erhardsteinhauer

  • tweak: Expanded the list of items that can be recycled to such an extent that salvaging may become a competitive alternative to mining for obtaining raw materials.

@chrome-cirrus
Copy link
Contributor

Awesome! This will be such a nice QoL thing... I hate that the only way to get rid of so many items is leaving them on a planet or hurling them into space for GC to eventually delete.

@dustylens
Copy link
Contributor

Literally my last thought as I logged out last night was that it seemed silly that I couldn't recycle pill canisters. Excellent initiative :D

@NafenX
Copy link

NafenX commented Oct 10, 2024

As someone who obsessively shoves things in the disposal and checks the reclaimer, often being disappointed at the large pile of things that somehow can't be processed in there, I'm especially happy to see this get amended. Things like ammo boxes not recycling is especially annoying, because isn't it just cardboard? Oftentimes people will dump spare ammo and magazines in the disposal and they just pile up. It also seems like individual bullets DO get recycled but I don't know if it's the sprite just being too small or something because they don't seem to automatically get taken in by the magnet when on a conveyor belt..

@ErhardSteinhauer
Copy link
Contributor Author

Can't think of anything else that'd be worth adding to the list, so I guess this is ready for review

@dvir001
Copy link
Contributor

dvir001 commented Oct 16, 2024

Wait for #2209 to confirm no issues.

@ErhardSteinhauer
Copy link
Contributor Author

Watch "integration tests" start bitching about recycled ammo boxes giving you more "carboard" than you used for crafting them (you used 0).

@github-actions github-actions bot added the Merge Conflict This PR has conflicts that prevent merging label Oct 17, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict This PR has conflicts that prevent merging label Oct 19, 2024
@GreaseMonk
Copy link
Contributor

wait for integration test testing still

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants