Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up the NSF Templar #2186

Merged
merged 15 commits into from
Oct 18, 2024
Merged

Conversation

chrome-cirrus
Copy link
Contributor

@chrome-cirrus chrome-cirrus commented Oct 10, 2024

About the PR

This PR modernizes the Templar substantially, quite similar to the Watchdog. Lots of changes including:

  • Directional fans instead of tiny fans
  • Two can atmos setup
  • NFSD livery decals and airlocks

Why / Balance

Compliance with tiny fan destruction guidelines, general modernization of one of the older/deadlier ship designs.

How to test

Spawn one in game, fly around, arrest some perps maybe.

Media

docked
subfloor
nodevis

Requirements

Breaking changes

Changelog

@github-actions github-actions bot added Map-Shuttle Map - Shuttle No C# labels Oct 10, 2024
@chrome-cirrus
Copy link
Contributor Author

Replaced the generator with some wall APUs per guidance from Dvir01. Moved the wall recharger to a table model in the cockpit so it's not accessible from outside.

@chrome-cirrus
Copy link
Contributor Author

Also added some firelocks to the new Templar, and to the Watchdog.

@Tych0theSynth
Copy link
Contributor

For additional neatness, you could move the waste vent under the port reverse thruster and remove that extra lattice. Looks good otherwise. I think the Templar has needed something like this for a while.

@chrome-cirrus
Copy link
Contributor Author

For additional neatness, you could move the waste vent under the port reverse thruster and remove that extra lattice. Looks good otherwise. I think the Templar has needed something like this for a while.

I've seen that on a few ships. Is that actually a valid placement if one had to rebuild it after damage or something? I kinda hate hiding components that way (as an engi/atmos player who has had a few "where is that goddamn vent?!" moments) but it would make for a cleaner look, it's true...

@Tych0theSynth
Copy link
Contributor

I've seen that on a few ships. Is that actually a valid placement if one had to rebuild it after damage or something? I kinda hate hiding components that way (as an engi/atmos player who has had a few "where is that goddamn vent?!" moments) but it would make for a cleaner look, it's true...

Yup, pretty certain it's valid. You can anchor machines on top of vents and scrubbers without affecting their output, plus if you need an engineer to fix something they will likely be using a t-ray and should be able to fathom it out.

@chrome-cirrus
Copy link
Contributor Author

I've seen that on a few ships. Is that actually a valid placement if one had to rebuild it after damage or something? I kinda hate hiding components that way (as an engi/atmos player who has had a few "where is that goddamn vent?!" moments) but it would make for a cleaner look, it's true...

Yup, pretty certain it's valid. You can anchor machines on top of vents and scrubbers without affecting their output, plus if you need an engineer to fix something they will likely be using a t-ray and should be able to fathom it out.

Nice, tested it out and that's totally a valid placement, so I moved that exhaust vent under the thruster. Thanks for questioning how it was initially! Was bugging me that the extra grid modified the ship's profile on radar, too...

dockedupdate

@Tych0theSynth
Copy link
Contributor

Looks good! It's what I always do unless I already have lots of external free lattice for practical reasons. It looks so much tidier.

@PeccNeck
Copy link
Contributor

Hmm.
image
Not sure what this guy's doing here. Not present on the Watchdog, either. Also not sure what the consensus is on interior fans like this. Either way, let it be known this straggler exists... for now.

@chrome-cirrus
Copy link
Contributor Author

chrome-cirrus commented Oct 10, 2024

Not sure what this guy's doing here. Not present on the Watchdog, either. Also not sure what the consensus is on interior fans like this. Either way, let it be known this straggler exists... for now.

Whoops! That door didn't start as an interior door in the OG Templar design so it had a fan on it, and I somehow didn't catch that while replacing the dang airlock with another variant. It's gone now.

@dvir001 dvir001 self-requested a review October 18, 2024 00:30
@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Oct 18, 2024
Copy link
Contributor

@dvir001 dvir001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@dvir001 dvir001 merged commit 6692ef5 into new-frontiers-14:master Oct 18, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Map-Shuttle Map - Shuttle No C# Status: Needs Review This PR is awaiting reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants