Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete rewrite of latejoin window #2200

Merged
merged 34 commits into from
Oct 13, 2024

Conversation

GreaseMonk
Copy link
Contributor

@GreaseMonk GreaseMonk commented Oct 12, 2024

About the PR

Redesign and complete rewrite of the latejoin menu.
Added more descriptions for options, described what each station purpose is, can easily be changed. The new code allows adding a icon , small description, and long description, and a sorting priority to a station.

For downstream i made it easy to skip the first large two button screen if they want and go directly to station or crew tab.
Search functionality is removed for now and will be reimplemented at a later time.

Why / Balance

The intent is to make new players to understand what they're getting into when pressing buttons by adding a small and long description for each station.

How to test

insert commands:
forcemap Frontier
setgamepreset Adventure
golobby
startround

  1. Start a game with latejoin lobby enabled.
  2. Press join button
  3. Click around things and join various jobs
  4. Buy a ship on one character and add some jobs to the station records computer
  5. Join stations and ships to test.

Some new edge cases:

  • If there are no stations where player can spawn on, the station button will show "There are no stations available at this time."
  • Same goes for crews.

Menus are designed to be recycleable.
Code has good separation of concerns.
Please note that the crew control code is going to be changed later on so it is a copy of the station control.

Media

image
image
image
image
frontier-thing

Requirements

Breaking changes

  • TickerJobsAvailableEvent has had its unreadable dictionary inside dictionary variables replaced with StationJobInformation

Changelog

🆑

  • remove: Removed old NFLatejoin menu
  • add: Added new LateJoin menu with more descriptive stations and station and crew separation

@github-actions github-actions bot added the YML label Oct 12, 2024
@GreaseMonk
Copy link
Contributor Author

please squash merge this pr when the time comes

@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Oct 12, 2024
@dvir001
Copy link
Contributor

dvir001 commented Oct 12, 2024

Based

@HandsomeTheEgg
Copy link

loaded up the branch and seems all working and nice looking i like it

Copy link
Contributor

@dvir001 dvir001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works

@dvir001 dvir001 merged commit 9eca8c3 into master Oct 13, 2024
13 checks passed
FrontierATC added a commit that referenced this pull request Oct 13, 2024
@GreaseMonk GreaseMonk deleted the fs-10-change-flow-of-join-game-screen branch October 13, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants