Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shuttle records console to allow copying ship deeds #2214

Open
wants to merge 23 commits into
base: master
Choose a base branch
from

Conversation

GreaseMonk
Copy link
Contributor

@GreaseMonk GreaseMonk commented Oct 13, 2024

About the PR

This adds a new Shuttle records console to the game that allows the station respresentative to put the deed of a ship onto the target ID card.

It is integrated with the new shuttle records system here:

This PR is blocked by #2212

Review it after this is merged for better overview
Copying is only enabled for ships NOT purchased at black market / syndicate

Why / Balance

According to dvir this has been a long requested feature for over a year and it was time to make it happen.

How to test

See video. the new console can be spawned (ShuttleRecordsConsole) or can be found in SR office

Media

Recording.2024-10-13.190714.aaaaaaaaaa.mp4

image

Requirements

Breaking changes

none

Changelog

🆑

  • add: Add shuttle records console that can copy deeds

@dvir001 dvir001 modified the milestone: Shuttle Improvements Oct 13, 2024
@github-actions github-actions bot added the Map-Outpost Map - Outpost label Oct 19, 2024
@GreaseMonk GreaseMonk added Status: Needs Review This PR is awaiting reviews and removed Status: DO NOT MERGE labels Oct 19, 2024
@CautionDev
Copy link

Maybe a remove deed button could also be added? That way SR can also remove deeds for ships that are inoperable and allow the owner to purchase a new one. Also would help in case the SR accidentally adds the incorrect ship and needs to fix it.

@GreaseMonk
Copy link
Contributor Author

Maybe a remove deed button could also be added? That way SR can also remove deeds for ships that are inoperable and allow the owner to purchase a new one. Also would help in case the SR accidentally adds the incorrect ship and needs to fix it.

it serves as a transaction history now, removing them could be added in a new PR if needed, im trying to keep PR's small

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# FTL Map-Outpost Map - Outpost Status: Needs Review This PR is awaiting reviews UI YML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants