Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CrateTrashCart contents exceeding maximum contents #2239

Merged
merged 3 commits into from
Oct 15, 2024
Merged

Conversation

GreaseMonk
Copy link
Contributor

@GreaseMonk GreaseMonk commented Oct 15, 2024

This fixes a integration test that tests if there is sufficient space for entities with StorageFillComponent.
image

I removed one item from it to make the test pass.

#2209

@dvir001
Copy link
Contributor

dvir001 commented Oct 15, 2024

Removed the mobs and dead mobs since they are just adding lags.

The crate can also spawn in space making it worst since they will just die as they spawn

@dvir001 dvir001 self-requested a review October 15, 2024 16:19
@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Oct 15, 2024
@dvir001 dvir001 merged commit e63ca18 into master Oct 15, 2024
12 checks passed
@GreaseMonk GreaseMonk deleted the fix-trash-cart branch October 15, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No C# Status: Needs Review This PR is awaiting reviews YML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants