Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TryIndex used with null param #2242

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Fix TryIndex used with null param #2242

merged 1 commit into from
Oct 15, 2024

Conversation

GreaseMonk
Copy link
Contributor

@GreaseMonk GreaseMonk commented Oct 15, 2024 •
edited by dvir001
Loading 

Caught exception in "entsys" Exception: System.ArgumentNullException: Value cannot be null. (Parameter 'key')

in this if-statement the job is null, causing the TryIndex to become null

Happens during SpawnAndDeleteEntityCountTest

#2209

@github-actions github-actions bot added the C# label Oct 15, 2024
@GreaseMonk GreaseMonk changed the title Fix a bad Fix TryIndex used with null param Oct 15, 2024
@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Oct 15, 2024
@dvir001 dvir001 merged commit 6a02d88 into master Oct 15, 2024
16 checks passed
@GreaseMonk GreaseMonk deleted the fix-appearance-change-nullref branch October 15, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvir001 dvir001 dvir001 approved these changes

@whatston3 whatston3 Awaiting requested review from whatston3

Assignees
No one assigned
Labels
C# Status: Needs Review This PR is awaiting reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GreaseMonk @dvir001