Adds some spookuary cheer from Bing and Ghost Prince. #2256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RSI Diff Bot; head commit 40172d7 merging into 1388224 Resources/Textures/_NF/Structures/Wallmounts/paintings.rsi
Resources/Textures/_NF/Structures/Wallmounts/paintings_directional.rsi
|
GreaseMonk
requested changes
Oct 16, 2024
Resources/Textures/_NF/Structures/Wallmounts/paintings_directional.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/_NF/Structures/Wallmounts/paintings.rsi/meta.json
Outdated
Show resolved
Hide resolved
whatston3
approved these changes
Oct 19, 2024
There was a problem hiding this comment.
Added construction graphs for streamers, made the entity names lowercase.
Licenses for paintings adjusted at Bing & GhostPrince's request.
Added a halloween-specific version of the random painting spawner (Thank you, Arimah, the holiday prototype swap code works wonders) and swapped it out for the regular random painting spawner on Halloween.
Added comments to the Frontier-specific HolidaySystem changes.
Looks alright to me, works fine under a modest amount of testing. Another pair of eyes on this would be appreciated, but I think it's good to go. Good stuff.
FrontierATC
added a commit
that referenced
this pull request
Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
This adds two paintings produced by Bing and Ghost Prince in addition to several seasonal banners. They're a delight. I made none of these.
Why / Balance
Spooktober
How to test
Place things. Check rotations of banners.
Media
Requirements
Breaking changes
Changelog
🆑