Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Computer Boards Fixup #2259

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Computer Boards Fixup #2259

merged 1 commit into from
Oct 16, 2024

Conversation

dvir001
Copy link
Contributor

@dvir001 dvir001 commented Oct 16, 2024

About the PR

Part of #2209

@github-actions github-actions bot added Status: Needs Review This PR is awaiting reviews YML C# and removed Status: Needs Review This PR is awaiting reviews labels Oct 16, 2024
whatston3
whatston3 approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only reference to the shipyard computer board is in its prototype, won't affect anything, and test changes look reasonable.

@whatston3 whatston3 merged commit e671e95 into new-frontiers-14:master Oct 16, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whatston3 whatston3 whatston3 approved these changes

Assignees
No one assigned
Labels
C# YML
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dvir001 @whatston3