Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shuttles generators shipyard tab #2271

Merged

Conversation

dvir001
Copy link
Contributor

@dvir001 dvir001 commented Oct 17, 2024

About the PR

Added shipyard generator tab

Why / Balance

More info more cool

How to test

Spawn and go to shipyard, filter for ships

Media

image

image

Requirements

Breaking changes

N/A

Changelog
N/A

@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Oct 17, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Merge Conflict This PR has conflicts that prevent merging label Oct 17, 2024
@github-actions github-actions bot removed the Merge Conflict This PR has conflicts that prevent merging label Oct 17, 2024
Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed "SM" to "Supermatter", reordered NFSD categories, replaced "Stealth" with "Patrol" and "Pursuit" classes, reordered NFSD categories to the top of the list (only shipyard with mixed groups apart from the lodge's console).

Display of the NFSD shipyard console below - NFSD-specific categories are first.
image

Looks fine to me, give it a look when you can, can revert if needed.

@whatston3 whatston3 merged commit bd89429 into new-frontiers-14:master Oct 19, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# FTL Map-Shuttle Map - Shuttle Status: Needs Review This PR is awaiting reviews UI YML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants