End of Round Cash Summary Revision #2276
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Reviews the end of round screen.
More information (entity user name, start balance, an invalid end balance, and user ID [for validation]) is saved on spawn. It is also saved per-entity. Every spawned player should now have an entry in the end of round screen. N.B. - this does not include ghost roles, does not include reformed dionas (could hijack the entity attach, but we might run into cache issues), but DOES include respawns as the same character (see media below).
The invalid end balance is filled on three conditions: early disconnect (using the player's session for balance lookup while it still exists), detach (ghost, cryo, etc.), and end of round (because we need the values now).
Some color was added to the header and cash value (blue and orange chosen to avoid colorblind issues, and a weaker association with "lose money bad")
The game type was removed from the end of round text (it adds nothing when it's fixed).
How to test
Media
Requirements
Breaking changes
Changelog
🆑