Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End of Round Cash Summary Revision #2276

Merged

Conversation

whatston3
Copy link
Contributor

@whatston3 whatston3 commented Oct 18, 2024

About the PR

Reviews the end of round screen.

More information (entity user name, start balance, an invalid end balance, and user ID [for validation]) is saved on spawn. It is also saved per-entity. Every spawned player should now have an entry in the end of round screen. N.B. - this does not include ghost roles, does not include reformed dionas (could hijack the entity attach, but we might run into cache issues), but DOES include respawns as the same character (see media below).

The invalid end balance is filled on three conditions: early disconnect (using the player's session for balance lookup while it still exists), detach (ghost, cryo, etc.), and end of round (because we need the values now).

Some color was added to the header and cash value (blue and orange chosen to avoid colorblind issues, and a weaker association with "lose money bad")

The game type was removed from the end of round text (it adds nothing when it's fixed).

How to test

  1. Spawn, deposit or withdraw money from the ATM.
  2. Disconnect, your character should be reported.
  3. Spawn, deposit, delete your entity.

Media

image

Requirements

Breaking changes

Changelog

🆑

  • fix: Values reported in the end of round screen are accurate again.

@dvir001 dvir001 self-requested a review October 18, 2024 14:29
@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Oct 18, 2024
Copy link
Contributor

@GreaseMonk GreaseMonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this also by going cryo and joining on another character, both of them will then be listed correctly.

@GreaseMonk GreaseMonk merged commit 25c6538 into new-frontiers-14:master Oct 18, 2024
14 checks passed
FrontierATC added a commit that referenced this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# FTL Status: Needs Review This PR is awaiting reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants