New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GeneratorSystem: no eject on empty #2291

Merged

dvir001 merged 2 commits into new-frontiers-14:master from whatston3:2024-10-19-no-fuel-when-generator-empty

Oct 20, 2024

Contributor

whatston3 commented Oct 20, 2024

About the PR

Stops generating fuel when a generator is empty.

Why / Balance

Bug. https://discord.com/channels/1123826877245694004/1296452037093101578

How to test

Spawn a solid fuel generator (PACMAN, SUPERPACMAN, HYPERPACMAN).
Try to eject, it should do nothing.
Insert fuel (plasma, uranium, bananium).
Try to eject, you should get fuel-grade material back.
Try to eject again, nothing should happen.

Media

Requirements

I have read and am following the Pull Request and Changelog Guidelines.
I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

🆑

fix: Solid fuel generators now no longer spawn fuel when ejecting while empty.


          GeneratorSystem: no eject on empty

fca14a9

github-actions bot added the C# label


          Merge branch 'master' into 2024-10-19-no-fuel-when-generator-empty

69422cb

dvir001 approved these changes

View reviewed changes

dvir001 merged commit 497231e into new-frontiers-14:master

13 checks passed

FrontierATC added a commit that referenced this pull request


          Automatic Changelog (#2291)

437d7ac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C#