Chatsan fixes to emote entries ending with letters.

[whatston3]

About the PR

Fixes Chatsan emote entries that end in letters by adding periods.

Why / Balance

Brainrot.

How to test

Enter the following text in in-game chat. Each one of them should result in an emote. Note that the >:i entry requires an additional > because of local chat.

:D
:O
:S
xD
qwq
:u
:v
>:i
:i
:p
;p
:b
o-o
o.o
smh
lmao
lmfao
lol
lel
kek
rofl
idk

Media

Requirements

• I have read and am following the Pull Request and Changelog Guidelines.
• I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

🆑

• fix: Chatsan emotes ending in letters now work again.

[GreyMario]

Isn't there code somewhere that's explicitly supposed to strip trailing punctuation... exactly for this purpose?

E: oh right that's buried in emote chatcode instead of being in a sane place

[dvir001]

Was this fixed on upstream?

[arimah]

There is a much simpler and more robust fix to these recurring issues:

frontier-station-14/Content.Server/Chat/Systems/ChatSystem.cs

Line 766 in 66f4a02

_sanitizer.TrySanitizeOutSmilies(newMessage, source, out newMessage, out emoteStr);

Move this line up above all the if statements. Check emotes first, then punctate and capitalise and stuff. Since this is inherited from upstream, we could probably even upstream that fix. It'll help everyone who uses the auto-punctuate feature.

[whatston3]

Move this line up above all the if statements. Check emotes first, then punctate and capitalise and stuff. Since this is inherited from upstream, we could probably even upstream that fix. It'll help everyone who uses the auto-punctuate feature.

If you'd like this done, I'd ask you to do it. I frankly hate this feature and tried to spend the minimum amount of time on it.

Thank you.

Changes made.

[whatston3]

Testbench in description works without issue.

[arimah]

Oh, I was just about to make the change. Well, thanks for doing it yourself, I suppose! I hate this feature too, but it is what it is.