Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rosy the Maple Mothroach Cloak #2296

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

dustylens
Copy link
Contributor

About the PR

Adds:

  • Rosy the maple Mothroach Cloak and hood, sprite by Bingususususus
  • Maple Mothroach pelt.
  • Maple mothroaches can now drop hides on butcher. This is very changeable. It seems high to me right now, but I don't have a good measuring stick for this sort of thing.

Tweaks:

  • Cloak added to mail pool. This can be removed if desired.

For the future:

  • Taxidermi, rugs, plushies. Probably add similar system for the normal mothroach. Keeping things simple gives good reference material for myself and other noobs.

Why / Balance

If it's cute we can skin it.

How to test

De-alive some rosy mothroaches. De-skin some rosy mothroaches with a knife. Craft the new apparel.
Check left/right hand states. Don ye now your pink apparel. Hood up.

I'm sure it goes without saying but, well, you know me. Please pass along reflections and criticisms regarding naming conventions and other places I can clean things up. This one in particular gave me some trouble to put together so I am very receptive to optimization suggestions.

Media

ss+(2024-10-20+at+08 45 56)

Requirements

Breaking changes

I'm not sure if this would cause conflicts with the ongoing efforts to make everything recyclable. If it does let me know how and I'll be sure to incorporate those fixes here and in future PRs.

Changelog

🆑

  • add: Rosy the Maple Mothroach cape.

Copy link
Contributor

github-actions bot commented Oct 21, 2024

RSI Diff Bot; head commit b01af9b merging into 1ccc3ab
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Clothing/Head/Hoods/rosy.rsi

State Old New Status
equipped-HELMET Added
icon Added

Resources/Textures/_NF/Clothing/Neck/Cloaks/rosy.rsi

State Old New Status
equipped-NECK Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Objects/Materials/rosymothroach.rsi

State Old New Status
hiderosymothroach Added

Edit: diff updated after b01af9b

@Tych0theSynth
Copy link
Contributor

Perfection. I've needed this.
You could consider adding it to loadouts but with a hefty price tag!

@dustylens
Copy link
Contributor Author

Perfection. I've needed this. You could consider adding it to loadouts but with a hefty price tag!

It was requested that it not be added to loadouts for the moment. With the preference instead being that it's something that one can put together for funsies. I've left it in the mail however, though that may also be changed.

@Tych0theSynth
Copy link
Contributor

It was requested that it not be added to loadouts for the moment. With the preference instead being that it's something that one can put together for funsies. I've left it in the mail however, though that may also be changed.

And here I was thinking the commit was just you trolling me.

@dustylens
Copy link
Contributor Author

It was requested that it not be added to loadouts for the moment. With the preference instead being that it's something that one can put together for funsies. I've left it in the mail however, though that may also be changed.

And here I was thinking the commit was just you trolling me.

It was just poorly timed as I noticed that, of course because I am a knucklehead who does knucklehead screwups on the regular, neglected to remove them from the contractor loadouts and noticed the check failure reminding me of my duty.

@dustylens
Copy link
Contributor Author

Perfection. I've needed this. You could consider adding it to loadouts but with a hefty price tag!

Remind me to make a Rosy the Maple Mothroach tablecloth before V day.

@github-actions github-actions bot added the Merge Conflict This PR has conflicts that prevent merging label Oct 21, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict This PR has conflicts that prevent merging label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants