Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space Dungeon generation: explicit list of prototypes, name dungeon grids. #2301

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

whatston3
Copy link
Contributor

@whatston3 whatston3 commented Oct 22, 2024

About the PR

Dungeon generation is currently done by enumerating all dungeon configs and removing ones we don't care about. This turns it into an explicitly whitelisted process, with the AdventureGameRule itself defining the set of space dungeons it generates.

All generated space dungeon grids will be given a name (e.g. "Space Dungeon: VirologyLab").

Haunted and Mineshaft, as they generate using rock walls, were removed from this whitelisted pool - they look odd having rock walls on a giant steel sheet in space.

Note: unsure if the dungeons generate well in Debug configs, but Release seems to work fine. The space platform itself should probably be removed in favour of having a crappy lattice that the dungeon sits on in space.

Why / Balance

Missed a dungeon config added upstream containing fultons.

How to test

  1. Start a round, check the admin grid list.
  2. Note: the 9 blank entries are still related to this dungeon generation, but I couldn't find where they were created.
  3. Warp to one as a ghost, fly outside of it and check the radar, it should not have an IFF name.

Media

To the right, the admin menu with the space dungeons listed. To the left, the CaveFactory dungeon.
image

Requirements

Breaking changes

Changelog

No changelog, negligible in-game effect.

@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Oct 22, 2024
@dvir001 dvir001 merged commit 7f840af into new-frontiers-14:master Oct 22, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# FTL Status: Needs Review This PR is awaiting reviews YML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants