Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handheld Mass Scanner #484

Merged
merged 6 commits into from
Oct 27, 2023
Merged

Handheld Mass Scanner #484

merged 6 commits into from
Oct 27, 2023

Conversation

Temoffy
Copy link
Contributor

@Temoffy Temoffy commented Oct 26, 2023

About the PR

Added handheld mass scanner.

Why / Balance

Very useful for spacewalks, search and rescue, and related spacewalk-inducing situations, like guiding a ship toward you rather then hoping they are good enough with a gps. Or making a short trip to a spaceship that spawned near the station.

Technical details

One yaml file, 2 pngs, and an extra if statement in the radar code.

Media

2023-10-25_19 34 56

2023-10-25_19 35 28

  • [ X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

None
Changelog

🆑

  • add: Handheld mass scanner in AstroVend!

@Kesiath
Copy link
Contributor

Kesiath commented Oct 26, 2023

Would be perfect to add to either AstroVend or BountyVend. Thanks for this!

@Cheackraze Cheackraze self-requested a review October 26, 2023 23:36
Copy link
Member

@Cheackraze Cheackraze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing.

Only two very minor issues that I fixed to get this in asap: sprite location needs to use forward slashes not back slashes, and your license had an extra space at the end.

@Cheackraze Cheackraze merged commit c96305f into new-frontiers-14:master Oct 27, 2023
9 of 11 checks passed
FrontierATC added a commit that referenced this pull request Oct 27, 2023
@TheShuEd
Copy link
Contributor

Hi. I forgot to ask a bit, but I hope you don't mind if I use your builds in the main game repository?
space-wizards/space-station-14#25526

@Temoffy
Copy link
Contributor Author

Temoffy commented Feb 25, 2024

I don't mind, but if you are making it official you really might want to see if you can lock the radar screen upward to the player's upward. It is currently based on the character's orientation because I couldn't figure out how to read the user's view angle. It would go in Content.Server/Shuttles/Systems/RadarConsoleSystem.cs line 39 if you can figure it out.

@TheShuEd
Copy link
Contributor

We've got a big mass scanner refactor coming up, I'll pass that along.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants