Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STC2 #569

Merged
merged 7 commits into from
Nov 13, 2023
Merged

STC2 #569

merged 7 commits into from
Nov 13, 2023

Conversation

dvir001
Copy link
Contributor

@dvir001 dvir001 commented Nov 12, 2023

About the PR

Fix STC radio, split into channels.

Why / Balance

The blackmarket no longer snitch with owner name, instead it will report to security with ship name only.

Technical details

C# update

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame.

Breaking changes

N/A

Changelog
🆑 dvir01

  • fix: STC Improved, the buy and sell notifications sent to correct channels.

@Cheackraze Cheackraze self-requested a review November 13, 2023 19:40
Copy link
Member

@Cheackraze Cheackraze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would have preffered a switch case and have the report method handle the logic of the channel based on the UIKey fed to it, but this will work for now

@Cheackraze Cheackraze merged commit f27b6a1 into new-frontiers-14:master Nov 13, 2023
8 of 10 checks passed
FrontierATC added a commit that referenced this pull request Nov 13, 2023
dvir001 pushed a commit to dvir001/frontier-station-14 that referenced this pull request Jan 1, 2024
Nothing much. Just a small quality of life.
Cheackraze pushed a commit that referenced this pull request Jan 2, 2024
* Fluffy tail for felinids (#433)

* Fluffy tail for felinids

After 9 years. I finished it.

(Requires Phil's approval, will put it to ready for review as soon as he gets to see fully the fully finished PR)

* An small update.

Updated meta.json to include all numbers to be equal.
Updated PNG to allow updated numbers to have actual sprites and not just empty sprites.

* Improved the tail sprite.

Proper animation and code.

* Updates ftl for it to properly work.

* Prevent shooting while inside a duffelbag (#510)

Anyone shoved into a duffelbag gets an ItemComponent. This denies anyone
with an ItemComponent from shooting a gun.

* Prevent pseudoitems from being transferred between bags  (#553)

* Update PseudoItemSystem.cs

* Rider full cleanup

* Also abort in sharedstorage

* Make the comp shared

* Why drop the bags?

* Make felinids meow it instead of sayin it. (#543)

* Make felinids meow it instead of sayin it.

A note: snapping doesnt even make a sound effect on humans. Only putting it just incase that ever gets fixed upstream.
Also fixes issue #525
A simple PR.

* Hopefully fixes yaml linter.

* Removes notes.

* Fixing

* FTL fix

* Missing FTL

* fix tattoos

* Updates more variation of mraowing. (#604)

Thats it.

* Allow vulpkaning to sigh. (#569)

Nothing much. Just a small quality of life.

* What the hell is even a yeep?

* Update felinid.yml

---------

Co-authored-by: Adrian16199 <144424013+Adrian16199@users.noreply.github.com>
Co-authored-by: Bakke <luringens@protonmail.com>
Co-authored-by: Debug <49997488+DebugOk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants