Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-balanced some practical vending machines, sorted and updated inventories #74

Merged
merged 26 commits into from
Jul 27, 2023
Merged

Re-balanced some practical vending machines, sorted and updated inventories #74

merged 26 commits into from
Jul 27, 2023

Conversation

sTiKyt
Copy link
Contributor

@sTiKyt sTiKyt commented Jul 23, 2023

About the PR

Trying to make prices make more sense and look more logical
Rich players would have to spend a bit more money, and poor and newbie players would have more motivation to seek other crews and learn how to play with them, before buying their own ships.

The amount of EVA suits was decreased by 5, and 5 basic hardsuits with a higher price were added. Basic hardsuits are a bit better than EVA.

Everything high-tech actually costs some reasonable money now, instead of being almost free.

Industrial welding tools are highly priced and there's only a small amount of them, ensuring they will be taken only by players who REALLY need them. As a bonus, now finding those tools while salvaging should profit small amount of cash.

It will be a bit harder to get fully equipped for beginner players, which should improve role-play a bit, as seeing fully equipped engineer for hire would become slightly less common.

Other changes I might have forgotten to mention can be seen on a picture below.

Media

image

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

🆑

  • add: Crusher Glaive, Industrial Welder, Advanced Industrial Welder and mining drill can now be found in Salvage Vendor
  • add: MV and HV cables can now be found in YouTool
  • add: small amount of basic hardsuits can now be found in AstroVend
  • fix: Now AstroVend, Salvage Vendor, Engi-Vend and YouTool prices make more sense and seem more logical
  • tweak: Sorted AstroVend, Salvage Vendor, Engi-Vend and YouTool inventories by putting more demanded items higher

@sTiKyt sTiKyt mentioned this pull request Jul 23, 2023
1 task
@Cheackraze
Copy link
Member

Tools in the salvage vendor are a bit bloat, should remove the welders and crowbar. In general it looks ok but some of these are a tad high imo and a bit overly restrictive, I will go though them probably tomorrow

@sTiKyt
Copy link
Contributor Author

sTiKyt commented Jul 23, 2023

Tools in the salvage vendor are a bit bloat, should remove the welders and crowbar. In general it looks ok but some of these are a tad high imo and a bit overly restrictive, I will go though them probably tomorrow

I think making thing a little less accessible would benefit RP, as players would have to depend on communications a bit more

@dvir001
Copy link
Contributor

dvir001 commented Jul 23, 2023

Tools in the salvage vendor are a bit bloat, should remove the welders and crowbar. In general it looks ok but some of these are a tad high imo and a bit overly restrictive, I will go though them probably tomorrow

I think making thing a little less accessible would benefit RP, as players would have to depend on communications a bit more

I can tell you for a fact that if you PR this changes ill just buy a proto to print tools to make mad money and lag the server with 10k entity.

You should never change the prices of items that could be printed to be more then the cost to print in a way like this.

@sTiKyt
Copy link
Contributor Author

sTiKyt commented Jul 23, 2023

Tools in the salvage vendor are a bit bloat, should remove the welders and crowbar. In general it looks ok but some of these are a tad high imo and a bit overly restrictive, I will go though them probably tomorrow

I think making thing a little less accessible would benefit RP, as players would have to depend on communications a bit more

I can tell you for a fact that if you PR this changes ill just buy a proto to print tools to make mad money and lag the server with 10k entity.

You should never change the prices of items that could be printed to be more then the cost to print in a way like this.

Proto price will obviously change as well, soon, right now there's no balance to most things, gotta find issues like this and slowly polish them out

@dvir001
Copy link
Contributor

dvir001 commented Jul 23, 2023

Tools in the salvage vendor are a bit bloat, should remove the welders and crowbar. In general it looks ok but some of these are a tad high imo and a bit overly restrictive, I will go though them probably tomorrow

I think making thing a little less accessible would benefit RP, as players would have to depend on communications a bit more

I can tell you for a fact that if you PR this changes ill just buy a proto to print tools to make mad money and lag the server with 10k entity.
You should never change the prices of items that could be printed to be more then the cost to print in a way like this.

Proto price will obviously change as well, soon, right now there's no balance to most things, gotta find issues like this and slowly polish them out

This has to be fixed in the same time, or you are creating new issues when updating prices.
Or leave the original prices to anything that could be printed please.

Resources/Prototypes/Entities/Objects/Tools/welders.yml Outdated Show resolved Hide resolved
Resources/Prototypes/Entities/Objects/Tools/welders.yml Outdated Show resolved Hide resolved
.vscode/tasks.json Outdated Show resolved Hide resolved
Resources/Prototypes/Entities/Objects/Tools/gps.yml Outdated Show resolved Hide resolved
@Cheackraze
Copy link
Member

Cheackraze commented Jul 23, 2023

in general we should stick with lowering the [StaticPrice] of the simple printed items and instead increasing the [MarketModifier] to increase their cost at the vending machine. That way its still not worth it to entity spam to create these entities but their availability is still limited by the cost (unless you buy/trade from real people, which is the ultimate goal here)

@sTiKyt
Copy link
Contributor Author

sTiKyt commented Jul 26, 2023

Updated Media section to correctly reflect this PR after changes

@Cheackraze Cheackraze self-requested a review July 27, 2023 01:27
@Cheackraze Cheackraze merged commit 7225f19 into new-frontiers-14:master Jul 27, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants