Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unreliable arming button in C firmware #14

Open
invd opened this issue Jan 30, 2022 · 1 comment · May be fixed by #24
Open

Unreliable arming button in C firmware #14

invd opened this issue Jan 30, 2022 · 1 comment · May be fixed by #24

Comments

@invd
Copy link

invd commented Jan 30, 2022

First of all, @nezza thank you for the C firmware!

On my unit, it's hit-or-miss whether pressing the "arming" button actually toggles the arming state as intended. In my impression, short clicks are slightly more reliable, but I don't see a clear pattern.
Typically, the arming-LED goes on or off briefly during the button click, but the overall state is not toggled and the LED reverts to the previous indication. This may be related to the button debouncing logic but I haven't looked at the code in any depth so far.

Changing the state via USB-serial is reliable and without any issues. I have not tried the micropython firmware version.

@nezza
Copy link
Collaborator

nezza commented Jan 30, 2022

Hey!

The debouncing is definitely a bit too enterprise-grade at the moment 🙃
I haven't encountered this issue yet, but will check in the next days

Cheers,
Thomas

@ar0n ar0n linked a pull request Oct 17, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants