Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/tests for onboarding #413

Merged
merged 5 commits into from
Feb 2, 2024
Merged

Add/tests for onboarding #413

merged 5 commits into from
Feb 2, 2024

Conversation

circlecube
Copy link
Member

Just a test PR to run onboarding tests in this plugin.

@circlecube circlecube self-assigned this Jan 16, 2024
@circlecube
Copy link
Member Author

I wanted to point this PR to the release branch, but am using main so that it will trigger the full matrix of tests. If and when tests show that they pass for this change, I plan to redirect it to the release branch.

Copy link

cypress bot commented Jan 16, 2024

Passing run #2662 ↗︎

0 314 24 0 Flakiness 0

Details:

i18n update for new string
Project: HostGator Plugin Commit: 38c8802a1b
Status: Passed Duration: 19:10 💡
Started: Jan 29, 2024 10:58 PM Ended: Jan 29, 2024 11:18 PM

Review all test suite changes for PR #413 ↗︎

@circlecube
Copy link
Member Author

Once there is a new onboarding module release incorporating these fixes: newfold-labs/wp-module-onboarding#419 we can bump the module version here and have onboarding tests in this plugin.

@circlecube circlecube changed the base branch from main to develop January 19, 2024 19:05
@circlecube
Copy link
Member Author

We can direct it to develop now though, since the previously mentioned release has already merged. It may be worth merging all the way to main so it can propagate to all other tests since they usually target main.

Base automatically changed from develop to main January 22, 2024 23:42
* develop:
  i18n updates
  coming soon settings component updates
  update coming soon module to v 1.1.18
  version bump to 2.6.2
  Composer(deps): Bump newfold-labs/wp-module-patterns
  Composer(deps): Bump newfold-labs/wp-module-data from 2.4.17 to 2.4.18
  Bump version to 2.6.1
  Update to data module 2.4.17
  Fix composer validation
  Prep release 2.6.0
  GitHub Actions(deps): Bump actions/cache from 3 to 4

# Conflicts:
#	cypress.config.js
this is the latest version which fixes tests
@circlecube
Copy link
Member Author

This would also take care of #430 since I updated to the latest onboarding module here. It was a release specifically targeting fixing the tests for HG.

@circlecube circlecube changed the base branch from main to develop February 2, 2024 19:58
@circlecube circlecube merged commit dd4fcaf into develop Feb 2, 2024
14 of 27 checks passed
@circlecube circlecube deleted the add/tests-for-onboarding branch February 2, 2024 19:58
@cypress cypress bot mentioned this pull request Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant