Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launch Button | Calling comingSoonAdminbarToggle on update of comingsoon state #599

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

ramyakrishnai
Copy link
Contributor

@ramyakrishnai ramyakrishnai commented Jun 26, 2024

Proposed changes

Jira: https://jira.newfold.com/browse/PRESS4-547

Screen.Recording.2024-06-26.at.5.37.18.PM.mov

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@ramyakrishnai ramyakrishnai changed the base branch from main to develop June 26, 2024 12:11
Copy link

cypress bot commented Jun 26, 2024

Passing run #3912 ↗︎

0 332 32 0 Flakiness 0

Details:

coming soon fixes
Project: HostGator Plugin Commit: ae1e2cb573
Status: Passed Duration: 23:13 💡
Started: Jun 26, 2024 12:10 PM Ended: Jun 26, 2024 12:33 PM

Review all test suite changes for PR #599 ↗︎

Copy link

cypress bot commented Jun 26, 2024

Passing run #3931 ↗︎

0 332 32 0 Flakiness 0

Details:

Merge ae1e2cb into a97218a...
Project: HostGator Plugin Commit: e8379e2a26 ℹ️
Status: Passed Duration: 24:23 💡
Started: Jun 26, 2024 12:16 PM Ended: Jun 26, 2024 12:40 PM

Review all test suite changes for PR #599 ↗︎

@wpalani wpalani merged commit 3d9e9d1 into develop Jun 26, 2024
26 of 46 checks passed
@wpalani wpalani deleted the fix/coming-soon branch June 26, 2024 18:24
@cypress cypress bot mentioned this pull request Jun 26, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants