Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/marketplace and tests #606

Merged
merged 6 commits into from
Jun 26, 2024
Merged

Conversation

circlecube
Copy link
Member

Proposed changes

Integrate the updated marketplace module. See bluehost/bluehost-wordpress-plugin#1127
Minor update to tests to make them use env vars for pluginId and appId where possible.
Minor update to i18n command and update files to include new strings.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@circlecube circlecube requested a review from wpalani June 26, 2024 20:37
@circlecube circlecube self-assigned this Jun 26, 2024
Copy link

cypress bot commented Jun 26, 2024

Passing run #3975 ↗︎

0 338 29 0 Flakiness 0

Details:

update i18n command to remove old json files and run i18n.
Project: HostGator Plugin Commit: b1cabda066
Status: Passed Duration: 22:18 💡
Started: Jun 26, 2024 8:35 PM Ended: Jun 26, 2024 8:58 PM

Review all test suite changes for PR #606 ↗︎

Copy link

cypress bot commented Jun 26, 2024

Passing run #3976 ↗︎

0 338 29 0 Flakiness 0

Details:

Merge b1cabda into 96f511e...
Project: HostGator Plugin Commit: b7051a8836 ℹ️
Status: Passed Duration: 23:38 💡
Started: Jun 26, 2024 8:40 PM Ended: Jun 26, 2024 9:03 PM

Review all test suite changes for PR #606 ↗︎

@circlecube circlecube merged commit 63be303 into develop Jun 26, 2024
6 checks passed
@circlecube circlecube deleted the update/marketplace-and-tests branch June 26, 2024 21:14
@circlecube circlecube added this to the July 10 Release milestone Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants