-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor check env and fossa cli #73
Merged
elaguerta-nr
merged 21 commits into
newrelic:main
from
newrelic-csec:refactor-check-env-fossa-cli
May 29, 2024
Merged
Refactor check env and fossa cli #73
elaguerta-nr
merged 21 commits into
newrelic:main
from
newrelic-csec:refactor-check-env-fossa-cli
May 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move custom property values to fossa job env
This reverts commit 2020e0d.
Pass FOSSA_API_KEY secret from caller to check_env Pass HAS_FOSSA_API_KEY output form check_end to caller
newrelic org @ main
lucasgonze
approved these changes
May 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues jump out at me.
cmboling
reviewed
May 28, 2024
cmboling
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor check-env and FOSSA CLI
Refactor all workflows to pull out duplicate code from
check_env
andfossa
jobs. Fix bugs that suppressed errors from FOSSA analyze, and incorrectly set thefossaAnalyzeResult
custom property.Refactors
check-env
duplicated code into a reusable workflow at .github/workflows/fossa-check-env.ymlcheck-env
job.Bugfixes
[ERROR]
in error logs (exact match)fossa analyze
that indicates an execution error. Failing error codes indicate a policy violation, which we don't want to block on at this time.HAS_FOSSA_TARGETS
andFOSSA_ANALYZE_RESULT
env variables to ""elixir-version
input variable