Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update custom-instrumentation-attributes-net.mdx #19644

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Update custom-instrumentation-attributes-net.mdx #19644

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ccaa1db
Update custom-instrumentation-attributes-net.mdx
neilpdx Jan 6, 2025
7f37a34
Update custom-instrumentation-attributes-net.mdx
newrelic707195 Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...ents/net-agent/custom-instrumentation/custom-instrumentation-attributes-net.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
* You must be willing to modify your source code. If you can't or don't want to modify your source code, use [custom instrumentation via XML](/docs/agents/net-agent/custom-instrumentation/custom-instrumentation-xml-net).
* Your project must have a reference to `NewRelic.Api.Agent.dll` (for example, installing the package and placing `using NewRelic.Api.Agent;` in your code). This package is in the [NuGet gallery](https://www.nuget.org/packages/NewRelic.Agent.Api/).
* The `Transaction` and `Trace` attributes must be applied to concrete implementations of methods. They cannot be applied on interfaces or super class method definitions.
* Avoid instrumenting top-level methods such as `Main()`, as these methods do not conclude until the application terminates, which may prevent data from being sent to New Relic.

Check failure on line 28 in src/content/docs/apm/agents/net-agent/custom-instrumentation/custom-instrumentation-attributes-net.mdx

View workflow job for this annotation

GitHub Actions / vale-linter 

[vale] reported by reviewdog 🐶
[Microsoft.Contractions] Use 'don't' instead of 'do not'.

Raw Output:
{"message": "[Microsoft.Contractions] Use 'don't' instead of 'do not'.", "location": {"path": "src/content/docs/apm/agents/net-agent/custom-instrumentation/custom-instrumentation-attributes-net.mdx", "range": {"start": {"line": 28, "column": 76}}}, "severity": "ERROR"}

Check warning on line 28 in src/content/docs/apm/agents/net-agent/custom-instrumentation/custom-instrumentation-attributes-net.mdx

View workflow job for this annotation

GitHub Actions / vale-linter 

[vale] reported by reviewdog 🐶
[Microsoft.Passive] 'being sent' looks like passive voice.

Raw Output:
{"message": "[Microsoft.Passive] 'being sent' looks like passive voice.", "location": {"path": "src/content/docs/apm/agents/net-agent/custom-instrumentation/custom-instrumentation-attributes-net.mdx", "range": {"start": {"line": 28, "column": 154}}}, "severity": "INFO"}

## Transactions called within transactions [#tx-vs-trace]

Expand Down
Loading