Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 504 errors to list of retryables #405

Closed

Conversation

griffitr
Copy link
Collaborator

We were finding intermittent instances of failed 504 Gateway Timeouts when the agent first tries to connect from a cell-based architecture. This resulted in a healthy instance of our application running, but without agent reporting. Allowing retries in the case of 504s has resolved the issue for us, and we think it may be beneficial for others.
@mattbaker

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Rena seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@mattbaker mattbaker self-requested a review August 25, 2023 18:20
Copy link
Contributor

@mattbaker mattbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trialed this ourselves first, the change was successful.

@mattbaker
Copy link
Contributor

@griffitr I wonder if you need to rebase to pick up XX's changes to the build stuff?

@griffitr griffitr closed this Dec 11, 2023
@griffitr griffitr deleted the add-504-status-to-retryable branch December 11, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants