Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[super-agent] Add tests to the pre-install job #1484

Merged

Conversation

kang-makes
Copy link
Contributor

Is this a new chart

No

What this PR does / why we need it:

Chart with missing values is redering while it should fail.

Checklist

  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [mychartname])

@kang-makes kang-makes requested review from a team September 23, 2024 14:44
@paologallinaharbur
Copy link
Member

paologallinaharbur commented Sep 24, 2024

I am adding as well some small fixes:

  • the job serviceAccount and roleBinding are missing the hook pre-updagrade
  • the way we are mounting the volume now is leading to an issue:
        message: 'failed to create task for container: failed to create shim task:
          OCI runtime create failed: runc create failed: unable to start container
          process: error during container init: error mounting "/var/lib/kubelet/pods/d7822316-18c0-450d-8f8c-b3d6017dd0b8/volume-subpaths/auth-secret-private-key/super-agent-deployment/2"
          to rootfs at "/etc/newrelic-super-agent/keys/from-secret.key": mount /var/lib/kubelet/pods/d7822316-18c0-450d-8f8c-b3d6017dd0b8/volume-subpaths/auth-secret-private-key/super-agent-deployment/2:/etc/newrelic-super-agent/keys/from-secret.key
          (via /proc/self/fd/6), flags: 0x5001: not a directory: unknown: Are you
          trying to mount a directory onto a file (or vice-versa)? Check if the specified
          host path exists and is the expected type'
  • organization_id -> organizationId in values.yaml
  • secret deletion fails since the service account did not have enough permissions
  • the injection of boolean env-vars does not work, since the super agents substitute "true" instead of true

Copy link
Contributor

@sigilioso sigilioso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I simply left a question in case we'd like to add a further explanation.

Thanks!

@paologallinaharbur paologallinaharbur merged commit 3a14768 into master Sep 25, 2024
11 checks passed
@paologallinaharbur paologallinaharbur deleted the kang-makes/add-more-unittest-to-super-agent branch September 25, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants