Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Infinite Tracing Protobuf v5 Files #1241

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

TimPansino
Copy link
Contributor

@TimPansino TimPansino commented Oct 17, 2024

Overview

  • Add infinite tracing pb2 file for protobuf v5+.
  • Add infinite tracing proto file for reference and future use.
  • Update tests for protobuf v5/v4 in tox.
  • Remove version check gatekeeping for using pb2 files and do a try except on import instead.

Copy link

github-actions bot commented Oct 17, 2024

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON bandit 4 0 4.99s
✅ PYTHON black 4 3 0 0.99s
❌ PYTHON flake8 4 40 0.47s
✅ PYTHON isort 4 3 0 0.31s
❌ PYTHON pylint 4 4 1.8s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 34.21053% with 25 lines in your changes missing coverage. Please review.

Project coverage is 53.72%. Comparing base (b550b0d) to head (450cadd).

Files with missing lines Patch % Lines
newrelic/core/infinite_tracing_v5_pb2.py 31.42% 23 Missing and 1 partial ⚠️
newrelic/core/infinite_tracing_pb2.py 66.66% 0 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (b550b0d) and HEAD (450cadd). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (b550b0d) HEAD (450cadd)
3 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1241       +/-   ##
===========================================
- Coverage   81.36%   53.72%   -27.64%     
===========================================
  Files         199      200        +1     
  Lines       21834    21871       +37     
  Branches     3462     3464        +2     
===========================================
- Hits        17766    11751     -6015     
- Misses       2925     9142     +6217     
+ Partials     1143      978      -165     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TimPansino TimPansino marked this pull request as ready for review October 24, 2024 22:32
@TimPansino TimPansino requested a review from a team as a code owner October 24, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants