-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Volume Slider feature; WebSettingsDropdown widget refactoring #138
base: master
Are you sure you want to change the base?
Conversation
…eb dropdown menu options
…ve unnecessary breaks
Done! 🎯 I've updated the I did a PR on the The fully updated branch is readily accessible for exploration and utilization. Fell free to access kindly refer to the following URL: Development branch of pod_player fork |
How can i disable volume bar? |
I dont see any way to disable it, can you make it configurable please using |
Done! @gauravmehta13 in fact, I hadn't implemented this option previously. It was an excellent suggestion. There is now the |
you are awesome thanks |
Hey @Jeferson505 |
@newtaDev, |
@Jeferson505 i belive this is an essential feature to have, |
@newtaDev, done! |
@Jeferson505 |
@newtaDev By I understood from the check lints failure:
The Dart SDK of Github Actions it's not updated. So, I believe just you can resolve that, maybe upgrading the Github Actions Dart SDK if it's possible. If I can help, please let me know how. |
Snapshot From the PR review
2
3
I was talking about the review changes in this PR ☝️☝️ |
Description
This pull request introduces the new
volume slider
feature and includes a refactoring of theWebSettingsDropdown
widget for improved aesthetics.Changes Made
volume slider
feature to enhance user control over audio settings.WebSettingsDropdown
widget to improve aesthetics.pubspec.yaml
file to stay current and leverage the latest features.Supported Platforms
This PR ensures compatibility and functionality across the following platforms:
Additional Notes
GitHub Actions Lint Analysis Failure
A GitHub Actions lint analysis check failed due to an outdated Dart SDK version. The current Dart SDK version is 3.0.6, while the GitHub Actions setup was using an older version (2.19.4). To ensure successful analysis, it's imperative to update the Flutter SDK version within GitHub Actions configuration.
Unnecessary Break Removal
In accordance with the Dart Team's recommendation, the
break
command within switch cases has been removed. This improves code readability and adheres to best practices. For more details, refer to: Dart Linter Rule - Unnecessary Breaks.Thank you for reviewing this pull request. Your feedback and suggestions are greatly appreciated.