[Spring Core] 강인화 미션 제출합니다. #98
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soundbar91
reviewed
Oct 6, 2024
Comment on lines
+25
to
+30
| if [ -f "$PID_FILE" ]; then | ||
| PID=$(cat $PID_FILE) | ||
| if ps -p $PID > /dev/null; then | ||
| echo "애플리케이션을 종료 중입니다. (PID: $PID)" | ||
| kill -15 $PID | ||
| sleep 5 |
There was a problem hiding this comment.
R
제가 이해한 게 맞는지 모르겠지만, PID 파일 내부에는 현재 실행 중인 PID 값이 들어가고 이 값을 이용해서 현재 실행 중인 프로세스를 종료하는 방식으로 이해를 했습니다.
deploy.sh에는 PID 파일에 값을 저장하는 로직이 안 보이는 것 같아서, 한 번 확인 부탁드립니다 !
Comment on lines
+21
to
+25
| public void run(String... args) { | ||
| jdbcTemplate.execute(""" | ||
| INSERT INTO member (name, email, password, role) | ||
| VALUES ('어드민', 'admin@email.com', 'password', 'ADMIN'), | ||
| ('브라운', 'brown@email.com', 'password', 'USER'); |
There was a problem hiding this comment.
A
repository를 사용하지 않고, jdbc를 이용해서 값을 넣어주셨군요 !
| import org.springframework.jdbc.core.JdbcTemplate; | ||
| import org.springframework.stereotype.Component; | ||
|
|
||
| @Profile("production") |
There was a problem hiding this comment.
R
production으로 설정을 하면, 애플리케이션 시작 클래스에 ActiveProfile 어노테이션을 작성을 해야할 거 같다는 생각이 들어요 !
There was a problem hiding this comment.
application.properties 파일에 spring.profiles.active=production 설정을 해두긴 했는데 애플리케이션 시작 클래스에 어노테이션 작성하는게 적절해 보여서 수정하도록 하겠습니다!
There was a problem hiding this comment.
아하! 설정 파일이 있었군요.. 놓치고 간 부분 하나 배워갑니다 !
Comment on lines
186
to
187
| @Value("${security.jwt.token.secret-key}") | ||
| private String secretKey; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7단계
8단계
9단계