Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the app itself using Vue to fix accessibility #1388

Merged
merged 20 commits into from
Nov 8, 2023
Merged

Make the app itself using Vue to fix accessibility #1388

merged 20 commits into from
Nov 8, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Oct 30, 2023 •
edited
Loading

Move the main app to Vue instead of handlebars + j.Query to align with our work on accessibility in the @nextcloud/vue project.

Screenshot of the new vue app

image

@susnux susnux self-assigned this Oct 30, 2023
@susnux susnux force-pushed the feat/vue-app branch 5 times, most recently from 222e971 to 42fd7d0 Compare November 8, 2023 11:51
susnux added 3 commits November 8, 2023 15:02
@susnux
chore: Migrate package to use vite for building and use Vue for UI
430b86f 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
fix: Allow directly navigating to a the filtered app view
5b9f53a 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
fix: Make the app navigation a second named router-view
c18aa03 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux marked this pull request as ready for review November 8, 2023 14:04
@susnux susnux changed the title [WIP] Make the app itself using Vue to fix accessibility Make the app itself using Vue to fix accessibility Nov 8, 2023
ShGKme
ShGKme reviewed Nov 8, 2023
View reviewed changes
src/routes.ts
Comment on lines +28 to +32
{
path: '/',
name: 'root',
redirect: { path: '/all' },
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to change the URL of the root page? Maybe use 'all' as a fallback value in one route?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes it easier as then the sidebar item for all activities is automatically active on the root page.
Otherwise the route does not match the navigation entry which needs more changes to work.

ShGKme
ShGKme reviewed Nov 8, 2023
View reviewed changes
src/components/Activity.vue Outdated Show resolved Hide resolved
ShGKme
ShGKme reviewed Nov 8, 2023
View reviewed changes
src/app.ts Outdated Show resolved Hide resolved
susnux and others added 7 commits November 8, 2023 15:37
@susnux @artonge
fix!: Make the setting for RSS feed to take a real boolean as value
1c2e6ef 
Co-authored-by: Louis <louis@chmn.me>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
feat: Implement ActivityFeed view
ad2e221 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
feat(Activity): Allow to show previews in Activity component
a92520c 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
fix: Load and show previews in the Activity app view
88787e2 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
fix: Adjust icons to Nextcloud default size of 20x20 px
c91d5ea 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
feat: Show loading indicator on activity feed
7472efe 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
fix!: Drop legacy scripts
29000ec 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux requested review from ShGKme and artonge November 8, 2023 15:17
susnux added 2 commits November 8, 2023 17:13
@susnux
fix(tests): Adjust unit tests
219ec1f 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
chore(deps): Update to stable nextcloud/vue and nextcloud/dialogs
158bb17 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
fix(tests): Adjust node tests to use vitest
b15a83a 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the feat/vue-app branch 9 times, most recently from 66659b3 to cb78c2b Compare November 8, 2023 21:07
@susnux
chore: Compile assets
80d57db 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
Copy link
Contributor Author

susnux commented Nov 8, 2023

I give up on this and used the compile bot, absolutely no idea what is going on with the CI when I build locally.

@susnux susnux merged commit 7e54459 into master Nov 8, 2023
36 checks passed
@susnux susnux deleted the feat/vue-app branch November 8, 2023 21:38
@susnux susnux mentioned this pull request Nov 9, 2023
Closed
@blizzz blizzz mentioned this pull request Nov 9, 2023
Merged
@github-actions GitHub Actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@ChristophWurst ChristophWurst mentioned this pull request Nov 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miaulalala miaulalala miaulalala approved these changes

@artonge artonge artonge approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@susnux susnux

Labels
3. to review feature: stream feedback-requested technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compatibility with @nextcloud/vue 8 [BITV]: Sidebar is broken
4 participants
@susnux @artonge @miaulalala @ShGKme