Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove global secret #3050

Closed
wants to merge 1 commit into from
Closed

remove global secret #3050

wants to merge 1 commit into from

Conversation

enoch85
Copy link
Member

@enoch85 enoch85 commented Jul 28, 2023 •
edited by szaimen
Loading

@enoch85
remove global secret
aeb5fd7 
Not needed since the PR is merged.

Signed-off-by: Daniel Hansson <mailto@danielhansson.nu>
@Zoey2936
Copy link
Collaborator

but it is still not released: https://github.com/nextcloud/spreed/blob/77965581c4031be75f64500ac7e0383dfba6886a/recording/src/nextcloud/talk/recording/Config.py#L128

@szaimen
Copy link
Collaborator

szaimen commented Aug 10, 2023

Seems to be included in 28

@szaimen szaimen marked this pull request as draft August 17, 2023 07:56
@szaimen
Copy link
Collaborator

szaimen commented Nov 15, 2023

Can be merged after #3570 is done

@szaimen
Copy link
Collaborator

szaimen commented Nov 16, 2023

Will be done in #3752

@szaimen szaimen closed this Nov 16, 2023
@szaimen szaimen deleted the enoch85-patch-1 branch November 16, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2. developing Work in progress blocked upstream
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@enoch85 @Zoey2936 @szaimen