Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the frontend #5016

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Refactor the frontend #5016

merged 1 commit into from
Aug 8, 2024

Conversation

docjyJ
Copy link
Collaborator

@docjyJ docjyJ commented Jul 21, 2024

This is best reviewed like this: https://github.com/nextcloud/all-in-one/pull/5016/files?diff=unified&w=1


Nextcloud AIO offers a lot of features.
The containers.twig file is very long and complicated.

My suggestion to improve and simplify future addition of new functionality is:

  • Separate each section into "components".
  • Improved accessibility by using html5 semantic elements like main or section
  • Improve the stylesheet and try to follow the Nextcloud theme more.

What do you think @szaimen?

If you think it's a good thing to work on, I can work on it.
If you have another vision to implement this, do not hesitate to share it.

@docjyJ
Copy link
Collaborator Author

docjyJ commented Jul 21, 2024

image

@szaimen
Copy link
Collaborator

szaimen commented Jul 22, 2024

Hi @docjyJ, thanks a lot for working on this! :)

I think refactoring this into smaller components and improving the html definitely makes sense.

However lets keep redesigning stuff for follow-ups (e.g. I would like to keep the header inside the body and outside the blue header bar for now)

php/data/.gitkeep Outdated Show resolved Hide resolved
php/session/.gitkeep Outdated Show resolved Hide resolved
php/composer.json Outdated Show resolved Hide resolved
@docjyJ
Copy link
Collaborator Author

docjyJ commented Jul 22, 2024

What do you think about that ?

https://symfony.com/bundles/ux-twig-component/current/index.html

@szaimen
Copy link
Collaborator

szaimen commented Jul 22, 2024

What do you think about that ?

https://symfony.com/bundles/ux-twig-component/current/index.html

Looks cool in general :)
Currently not sure where we could use that though...

@docjyJ docjyJ force-pushed the enh/noid/better-front branch 2 times, most recently from bd9abf2 to 634e624 Compare July 24, 2024 16:45
@szaimen szaimen added 2. developing Work in progress enhancement New feature or request labels Jul 25, 2024
@docjyJ
Copy link
Collaborator Author

docjyJ commented Jul 29, 2024

@szaimen, maybe we could merge this PR with the #5007?

@szaimen
Copy link
Collaborator

szaimen commented Aug 1, 2024

@szaimen, maybe we could merge this PR with the #5007?

I'd personally like to keep it separate. However you could base this PR on top of my changes in #5007 if you want :)

@docjyJ
Copy link
Collaborator Author

docjyJ commented Aug 1, 2024

It's quite complicated to separate into several files. I don't think it's relevant and it risks breaking the interface.

I think this PR can be merged.
List of additions:

  • Use <main> instead of the content class
  • Paragraphs are in <p> and remove the <br>
  • Added an alt to the nextcloud logo.
  • Fix the logout button.

@docjyJ docjyJ marked this pull request as ready for review August 1, 2024 11:38
@docjyJ docjyJ requested a review from szaimen August 1, 2024 11:39
@szaimen
Copy link
Collaborator

szaimen commented Aug 2, 2024

All right. I try to review and schedule it for the next release :)

@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 2, 2024
@szaimen szaimen added this to the next milestone Aug 2, 2024
@docjyJ
Copy link
Collaborator Author

docjyJ commented Aug 2, 2024

It's quite complicated to separate into several files. I don't think it's relevant and it risks breaking the interface.

I think this PR can be merged. List of additions:

  • Use instead of the content class
  • Paragraphs are in

    and remove the

  • Added an alt to the nextcloud logo.
  • Fix the logout button.

I forgot that github supports html syntax...
I just saw the unreadable rendering with the tags...

Containers/mastercontainer/Dockerfile Outdated Show resolved Hide resolved
Signed-off-by: Jean-Yves <7360784+docjyJ@users.noreply.github.com>
Signed-off-by: Simon L. <szaimen@e.mail.de>
Copy link
Collaborator

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works apart from two small problems with buttons that can be addressed in a follow-up:

image
image

Thanks a lot! :)

@szaimen szaimen merged commit 69a3087 into main Aug 8, 2024
7 checks passed
@szaimen szaimen deleted the enh/noid/better-front branch August 8, 2024 14:39
@szaimen
Copy link
Collaborator

szaimen commented Sep 4, 2024

This is now released with 9.5.0 Beta. Testing and feedback is welcome! See https://github.com/nextcloud/all-in-one#how-to-switch-the-channel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants