-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the frontend #5016
Refactor the frontend #5016
Conversation
8b64e26
to
ec71781
Compare
Hi @docjyJ, thanks a lot for working on this! :) I think refactoring this into smaller components and improving the html definitely makes sense. However lets keep redesigning stuff for follow-ups (e.g. I would like to keep the header inside the body and outside the blue header bar for now) |
What do you think about that ? https://symfony.com/bundles/ux-twig-component/current/index.html |
Looks cool in general :) |
bd9abf2
to
634e624
Compare
70e8f0e
to
a6e4f5e
Compare
It's quite complicated to separate into several files. I don't think it's relevant and it risks breaking the interface. I think this PR can be merged.
|
All right. I try to review and schedule it for the next release :) |
I forgot that github supports html syntax... |
5b7089a
to
cd826ca
Compare
Signed-off-by: Jean-Yves <7360784+docjyJ@users.noreply.github.com> Signed-off-by: Simon L. <szaimen@e.mail.de>
cd826ca
to
bc6dfe8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now released with 9.5.0 Beta. Testing and feedback is welcome! See https://github.com/nextcloud/all-in-one#how-to-switch-the-channel |
This is best reviewed like this: https://github.com/nextcloud/all-in-one/pull/5016/files?diff=unified&w=1
Nextcloud AIO offers a lot of features.
The
containers.twig
file is very long and complicated.My suggestion to improve and simplify future addition of new functionality is:
main
orsection
What do you think @szaimen?
If you think it's a good thing to work on, I can work on it.
If you have another vision to implement this, do not hesitate to share it.