-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GitubActions Docker issue #318
Fix GitubActions Docker issue #318
Conversation
Signed-off-by: wiktor2200 <wiktor2200@users.noreply.github.com>
c77315c
to
ea19c67
Compare
Signed-off-by: wiktor2200 <wiktor2200@users.noreply.github.com>
ea19c67
to
a3fd5cc
Compare
3e46c4e
to
cf92c7b
Compare
Hi! @staticdev @aalaesar I've tried to fix a problem with docker molecule test but I got run out of idea. Would you be able to take a look and see? Maybe you will have some other solutions for this problem? @geerlingguy Sorry for bothering you, but maybe you have got any idea what could have gone wrong here? Have you ever seen such error in yours Ansible images?
|
Signed-off-by: wiktor2200 <wiktor2200@users.noreply.github.com>
cf92c7b
to
88e3f17
Compare
Hello @wiktor2200 thank you for taking some time to fix the CI. Edit: just thought. maybe we are upgrading ansible toot fast with dependabot for us to follow ansibles/molecule changes. Regards |
It looks like the error is:
I've seen similar file mount issues in GitHub Actions sometimes, but haven't in the past few months. Is this only with debian12? |
Hello Jeff! thanks a lot for involvement, I really appreciate that :) When we were searching for this issue, there is not many issues found, that's why I asked. ansible-collection-nextcloud-admin/.github/workflows/tests.yml Lines 20 to 23 in 20ab659
Then running it with:
Molecule itself it defined here: ansible-collection-nextcloud-admin/molecule/default/molecule.yml Lines 7 to 15 in 20ab659
And as it's matrix when once fails, rest are cancelled. In this PR I've tried to clean docker cache (inspired with your old blog post: https://www.jeffgeerling.com/blog/2018/testing-your-ansible-roles-molecule) and then |
Hello there |
hello all, I have been super busy with some other ansible issues, construction (like @geerlingguy =p) and don't really understand why this issue is happening. most my roles are tested against the same images and I don't have such an error. I would say to try using podman instead of docker since I mostly replaced docker for podman now. it is an alternative solution |
3288e04
to
b838c39
Compare
b838c39
to
a97c8e5
Compare
.github/workflows/tests.yml
Outdated
@@ -44,9 +44,9 @@ jobs: | |||
|
|||
- name: Install test dependencies | |||
run: | | |||
python3 -m pip install --constraint=.github/workflows/constraints.txt ansible 'molecule-plugins[docker]' docker netaddr | |||
python3 -m pip install --constraint=.github/workflows/constraints.txt ansible 'molecule-plugins[podman]' podman netaddr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding podman
is not necessary
@@ -16,8 +16,7 @@ jobs: | |||
fetch-depth: 0 | |||
|
|||
- name: Run ansible-lint | |||
# replace `main` with any valid ref, or tags like `v6` | |||
uses: ansible/ansible-lint-action@v6 | |||
uses: ansible/ansible-lint@v6.22.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is making some new complains about linting.. at least I see the logs from latest execution showing 2 errors. I would keep it separate from this PR.
@@ -28,6 +28,10 @@ jobs: | |||
with: | |||
path: "nextcloud.ansible-collection-nextcloud-admin" | |||
|
|||
- name: Clean docker cache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those lines also do not make sense when you are testing podman.
@wiktor2200 Thanks for trying it out. I saw some potential issues with current state of the PR on comments. |
Hello there. |
initial issue is gone now and CI has been fixed to work now. closing |
No description provided.