Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitubActions Docker issue #318

Closed
wants to merge 9 commits into from
Closed

Fix GitubActions Docker issue #318

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
399524e
Fix GitubActions Docker issue
wiktor2200 Nov 11, 2023
a3fd5cc
test molecule destroy before test
wiktor2200 Nov 11, 2023
88e3f17
add -f parameter to avoid prompt
wiktor2200 Nov 11, 2023
f438bf8
Test podman configuration
wiktor2200 Nov 27, 2023
18f136d
update lint action
wiktor2200 Nov 27, 2023
b368d97
podman dependencies
wiktor2200 Nov 27, 2023
a97c8e5
test podman priviledged setting
wiktor2200 Nov 27, 2023
7ed3432
remove priviledged
wiktor2200 Nov 28, 2023
1d50449
restore privileged
wiktor2200 Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,9 @@ jobs:

- name: Install test dependencies
run: |
python3 -m pip install --constraint=.github/workflows/constraints.txt ansible 'molecule-plugins[docker]' docker netaddr
python3 -m pip install --constraint=.github/workflows/constraints.txt ansible 'molecule-plugins[podman]' podman netaddr
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding podman is not necessary


- name: Run Molecule tests
- name: Run Molecule tests with Podman
run: |
molecule reset
molecule test
Expand Down
8 changes: 2 additions & 6 deletions .github/workflows/tests_latest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,6 @@ jobs:
with:
path: "nextcloud.ansible-collection-nextcloud-admin"

- name: Clean docker cache
run: |
docker system prune --volumes -a -f

- name: Set up Python
uses: actions/setup-python@v4
with:
Expand All @@ -43,9 +39,9 @@ jobs:

- name: Install test dependencies
run: |
python3 -m pip install --constraint=.github/workflows/constraints.txt ansible 'molecule-plugins[docker]' docker netaddr
python3 -m pip install --constraint=.github/workflows/constraints.txt ansible 'molecule-plugins[podman]' podman netaddr

- name: Run Molecule tests
- name: Run Molecule tests with Podman
run: |
molecule reset
molecule test
Expand Down
2 changes: 1 addition & 1 deletion molecule/default/molecule.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ role_name_check: 1
dependency:
name: galaxy
driver:
name: docker
name: podman
platforms:
- name: instance
image: "docker.io/geerlingguy/docker-${MOLECULE_DISTRO:-debian12}-ansible:latest"
Expand Down
Loading