Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: file actions redirect, v2 api version #284

Merged
merged 16 commits into from
May 8, 2024
Merged

Conversation

andrey18106
Copy link
Collaborator

@andrey18106 andrey18106 commented May 7, 2024

This PR introduces a simple File Actions menu redirect option to open ExApp UI page with the context of selected files.

Resolves: #136

Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
@andrey18106 andrey18106 requested a review from bigcat88 as a code owner May 7, 2024 06:27
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
andrey18106 and others added 5 commits May 7, 2024 09:53
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
bigcat88 and others added 4 commits May 7, 2024 13:45
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
@bigcat88
Copy link
Member

bigcat88 commented May 8, 2024

For returning empty Response from ExApp it fails:

TypeError: n.data is not an Object. (evaluating '"redirect_handler"in n.data')
(anonymous function) — filesplugin28.js:71

Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
Copy link
Member

@bigcat88 bigcat88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, now it's fine

@andrey18106 andrey18106 enabled auto-merge (squash) May 8, 2024 12:12
@andrey18106 andrey18106 merged commit 139e793 into main May 8, 2024
30 checks passed
@andrey18106 andrey18106 deleted the file-actions-redirect branch May 8, 2024 12:20
bigcat88 added a commit to cloud-py-api/nc_py_api that referenced this pull request May 8, 2024
Now in ExApp you can conveniently accept many files at once, and this is
very cool 🥳

Reference: nextcloud/app_api#284

---------

Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow FileActions to handle selected file in the UI of ExApp
2 participants